updated to run on jdk8

Author: joviegas

test/http-client-benchmarks/pom.xml

@@ -32,7 +32,7 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <jmh.version>1.37</jmh.version>
-        <javac.target>21</javac.target>
+        <javac.target>8</javac.target>
         <uberjar.name>http-client-benchmarks</uberjar.name>
         <exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
     </properties>

test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/UnifiedBenchmarkRunner.java

@@ -31,14 +31,32 @@
 import software.amazon.awssdk.benchmark.core.BenchmarkResult;
 import software.amazon.awssdk.benchmark.metrics.CloudWatchMetricsPublisher;
 import software.amazon.awssdk.regions.Region;
-
 import java.time.Instant;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
+import software.amazon.awssdk.benchmark.apache5.Apache5VirtualBenchmark;
 
-public class UnifiedBenchmarkRunner {
+public final class UnifiedBenchmarkRunner {
     private static final Logger logger = Logger.getLogger(UnifiedBenchmarkRunner.class.getName());
 
+    private UnifiedBenchmarkRunner() {
+    }
+
+    private static boolean isJava21OrHigher() {
+        String version = System.getProperty("java.version");
+        if (version.startsWith("1.")) {
+            version = version.substring(2);
+        }
+        int dotPos = version.indexOf('.');
+        int majorVersion;
+        if (dotPos != -1) {
+            majorVersion = Integer.parseInt(version.substring(0, dotPos));
+        } else {
+            majorVersion = Integer.parseInt(version);
+        }
+        return majorVersion >= 21;
+    }
+
     public static void main(String[] args) throws Exception {
         logger.info("Starting unified benchmark comparison");
 
@@ -56,12 +74,17 @@ public static void main(String[] args) throws Exception {
             allResults.addAll(runBenchmark("Apache4", Apache4Benchmark.class, null));
 
             // Run Apache5 with platform threads
-            logger.info("Running Apache5 with platform threads...");
-            allResults.addAll(runBenchmark("Apache5-Platform", Apache5Benchmark.class, "platform"));
-
-            // Run Apache5 with virtual threads
-            logger.info("Running Apache5 with virtual threads...");
-            allResults.addAll(runBenchmark("Apache5-Virtual", Apache5Benchmark.class, "virtual"));
+            logger.info("Running Apache5...");
+            allResults.addAll(runBenchmark("Apache5", Apache5Benchmark.class, null));
+
+            // Only run virtual threads benchmark if Java 21+
+            if (isJava21OrHigher()) {
+                logger.info("Running Apache5 with virtual threads...");
+                allResults.addAll(runBenchmark("Apache5-Virtual", Apache5VirtualBenchmark.class, null));
+            } else {
+                logger.info("Skipping virtual threads benchmark - requires Java 21 or higher (current: " +
+                            System.getProperty("java.version") + ")");
+            }
 
             // Debug: Print all results to understand the structure
             logger.info("All benchmark results:");
@@ -95,10 +118,6 @@ private static List<BenchmarkResult> runBenchmark(String clientType,
             .warmupIterations(2)
             .measurementIterations(3);
 
-        if (executorType != null) {
-            optBuilder.param("executorType", executorType);
-        }
-
         Options opt = optBuilder.build();
         Collection<RunResult> runResults = new Runner(opt).run();
 
@@ -176,14 +195,14 @@ private static void printBenchmarkSummary(List<BenchmarkResult> results) {
             return;
         }
 
-        System.out.println("\n" + "=".repeat(140));
+        System.out.println("\n" + repeatString("=", 140));
         System.out.println("BENCHMARK RESULTS SUMMARY");
-        System.out.println("=".repeat(140));
+        System.out.println(repeatString("=", 140));
 
         // Print header
         System.out.printf("%-20s | %-50s | %-15s | %-15s | %-15s | %-10s%n",
                           "Client Type", "Benchmark", "Throughput", "Avg Latency", "P99 Latency", "Threads");
-        System.out.println("-".repeat(140));
+        System.out.println(repeatString("-", 140));
 
         // Sort results for better readability
         List<BenchmarkResult> sortedResults = results.stream()
@@ -206,9 +225,9 @@ private static void printBenchmarkSummary(List<BenchmarkResult> results) {
                               result.getThreadCount());
         }
 
-        System.out.println("=".repeat(140));
+        System.out.println(repeatString("=", 140));
         System.out.printf("Total benchmark results: %d%n", sortedResults.size());
-        System.out.println("=".repeat(140));
+        System.out.println(repeatString("=", 140));
         // Print performance comparison in between Apache clients
         printApachePerformanceComparison(results);
 
@@ -220,7 +239,7 @@ private static void printApachePerformanceComparison(List<BenchmarkResult> resul
         }
 
         System.out.println("\nPERFORMANCE COMPARISON (Apache5 vs Apache4):");
-        System.out.println("=".repeat(80));
+        System.out.println(repeatString("=", 80));
 
         Map<String, List<BenchmarkResult>> groupedResults = results.stream()
                                                                    .filter(r -> r != null && r.getBenchmarkName() != null)
@@ -241,7 +260,7 @@ private static void printApachePerformanceComparison(List<BenchmarkResult> resul
             }
 
             System.out.printf("\n%s:%n", benchmarkName);
-            System.out.println("-".repeat(80));
+            System.out.println(repeatString("-", 80));
 
             for (BenchmarkResult result : benchmarkResults) {
                 if (result.getClientType() != null && !result.getClientType().equals("Apache4")) {
@@ -258,7 +277,14 @@ private static void printApachePerformanceComparison(List<BenchmarkResult> resul
             }
         }
 
-        System.out.println("\n" + "=".repeat(80));
+        System.out.println("\n" + repeatString("=", 80));
     }
 
+    private static String repeatString(String str, int count) {
+        StringBuilder sb = new StringBuilder(str.length() * count);
+        for (int i = 0; i < count; i++) {
+            sb.append(str);
+        }
+        return sb.toString();
+    }
 }

test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache4/Apache4Benchmark.java

@@ -59,7 +59,7 @@ public class Apache4Benchmark implements CoreBenchmark {
     @Param({"50"})
     private int maxConnections;
 
-    @Param({"10"})
+    @Param({"20"})
     private int threadCount;
 
     private S3Client s3Client;

test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java

@@ -46,6 +46,20 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.logging.Logger;
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
 
 @BenchmarkMode(Mode.Throughput)
 @OutputTimeUnit(TimeUnit.SECONDS)
@@ -62,7 +76,7 @@ public class Apache5Benchmark implements CoreBenchmark {
     @Param({"10"})
     private int threadCount;
 
-    @Param({"platform", "virtual"})
+    @Param({"platform"})
     private String executorType;
 
     private S3Client s3Client;
@@ -71,8 +85,7 @@ public class Apache5Benchmark implements CoreBenchmark {
 
     @Setup(Level.Trial)
     public void setup() {
-        logger.info("Setting up Apache5 benchmark with maxConnections=" + maxConnections +
-                    ", executorType=" + executorType);
+        logger.info("Setting up Apache5 benchmark with maxConnections=" + maxConnections);
 
         // Apache 5 HTTP client
         SdkHttpClient httpClient = Apache5HttpClient.builder()
@@ -96,18 +109,13 @@ public void setup() {
         benchmark = new S3BenchmarkImpl(s3Client);
         benchmark.setup();
 
-        // Create appropriate executor based on parameter
-        if ("virtual".equals(executorType)) {
-            executorService = Executors.newVirtualThreadPerTaskExecutor();
-            logger.info("Using virtual thread executor");
-        } else {
-            executorService = Executors.newFixedThreadPool(threadCount, r -> {
-                Thread t = new Thread(r);
-                t.setName("apache5-platform-worker-" + t.getId());
-                return t;
-            });
-            logger.info("Using platform thread executor");
-        }
+        // Always use platform threads
+        executorService = Executors.newFixedThreadPool(threadCount, r -> {
+            Thread t = new Thread(r);
+            t.setName("apache5-platform-worker-" + t.getId());
+            return t;
+        });
+        logger.info("Using platform thread executor");
 
         logger.info("Apache5 benchmark setup complete");
     }