Skip to content

Commit 88f403c

Browse files
committed
Run payload signing tests
We don't force payload signing for `http` endpoints, but it's possible to enable payload signing now by for `https` endpoints.
1 parent 4c82d9f commit 88f403c

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

test/s3-tests/src/it/java/software/amazon/awssdk/services/s3/regression/upload/UploadAsyncRegressionTesting.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,8 @@ void putObject(UploadConfig config) throws Exception {
5757
Assumptions.assumeFalse(config.getBodyType() == BodyType.CONTENT_PROVIDER_WITH_LENGTH,
5858
"No way to create AsyncRequestBody by giving both an Publisher and the content length");
5959

60-
// Payload signing doesn't work correctly for async java based
61-
// TODO(sra-identity-auth) remove when chunked encoding support is added in async code path
62-
Assumptions.assumeFalse(config.isPayloadSigning()
63-
// MRAP requires body signing
64-
|| config.getBucketType() == BucketType.MRAP,
65-
"Async payload signing doesn't work with Java based clients");
60+
Assumptions.assumeFalse(config.getBucketType() == BucketType.MRAP,
61+
"Async does not support currently Sigv4a");
6662

6763
// Async java based clients don't support unknown content-length bodies
6864
Assumptions.assumeTrue(config.getBodyType().isContentLengthAvailable(),

0 commit comments

Comments
 (0)