Fix connectionPoolingWorks by setting skipping setConnectionTimeToLive is value is set to 0 since 0 is treated as Infinite timeToLive in Sdk and Apache 4.x but treated as immediate closeConnection in apache 5.x

Author: joviegas

http-clients/apache5-client/src/main/java/software/amazon/awssdk/http/apache5/Apache5HttpClient.java

@@ -694,16 +694,17 @@ public PoolingHttpClientConnectionManager create(Apache5HttpClient.DefaultBuilde
             // TODO : Deprecated method needs to be removed with new replacements
             SSLConnectionSocketFactory sslsf = getPreferredSocketFactory(configuration, standardOptions);
 
-            PoolingHttpClientConnectionManager cm =
+            PoolingHttpClientConnectionManagerBuilder builder =
                 PoolingHttpClientConnectionManagerBuilder.create()
                                                          .setSSLSocketFactory(sslsf)
                                                          .setSchemePortResolver(DefaultSchemePortResolver.INSTANCE)
-                                                         .setDnsResolver(configuration.dnsResolver)
-                                                         .setConnectionTimeToLive(
-                                                             TimeValue.of(standardOptions.get(
-                                                                 SdkHttpConfigurationOption.CONNECTION_TIME_TO_LIVE).toMillis(),
-                                                                          TimeUnit.MILLISECONDS))
-                                                         .build();
+                                                         .setDnsResolver(configuration.dnsResolver);
+            Duration connectionTtl = standardOptions.get(SdkHttpConfigurationOption.CONNECTION_TIME_TO_LIVE);
+            if (!connectionTtl.isZero()) {
+                // Skip TTL=0 to maintain backward compatibility (infinite in 4.x vs immediate expiration in 5.x)
+                builder.setConnectionTimeToLive(TimeValue.of(connectionTtl.toMillis(), TimeUnit.MILLISECONDS));
+            }
+            PoolingHttpClientConnectionManager cm = builder.build();
 
 
             cm.setDefaultMaxPerRoute(standardOptions.get(SdkHttpConfigurationOption.MAX_CONNECTIONS));

http-clients/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/Apache5HttpClientWireMockTest.java

@@ -153,12 +153,6 @@ public void credentialPlannerIsInvoked() throws Exception {
         mockProxyServer.verify(2, RequestPatternBuilder.allRequests());
     }
 
-
-    @Override
-    public void connectionPoolingWorks() throws Exception {
-        // TODO : future PR will handle this.
-    }
-
     @Test
     public void overrideDnsResolver_WithDnsMatchingResolver_successful() throws Exception {
         overrideDnsResolver("magic.local.host");