Skip to content

Commit 8db0b7c

Browse files
authored
Make SyncClientClass extend SyncClientInterface (#3740)
* Make SyncClientClass extend SyncClientInterface * remove unused import * Make SyncClientInterface not final
1 parent ed02bcc commit 8db0b7c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/SyncClientClass.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel;
4444
import software.amazon.awssdk.codegen.model.intermediate.OperationModel;
4545
import software.amazon.awssdk.codegen.model.intermediate.Protocol;
46-
import software.amazon.awssdk.codegen.poet.ClassSpec;
4746
import software.amazon.awssdk.codegen.poet.PoetExtension;
4847
import software.amazon.awssdk.codegen.poet.PoetUtils;
4948
import software.amazon.awssdk.codegen.poet.client.specs.Ec2ProtocolSpec;
@@ -64,15 +63,15 @@
6463
import software.amazon.awssdk.metrics.NoOpMetricCollector;
6564
import software.amazon.awssdk.utils.Logger;
6665

67-
//TODO Make SyncClientClass extend SyncClientInterface (similar to what we do in AsyncClientClass)
68-
public class SyncClientClass implements ClassSpec {
66+
public class SyncClientClass extends SyncClientInterface {
6967

7068
private final IntermediateModel model;
7169
private final PoetExtension poetExtensions;
7270
private final ClassName className;
7371
private final ProtocolSpec protocolSpec;
7472

7573
public SyncClientClass(GeneratorTaskParams taskParams) {
74+
super(taskParams.getModel());
7675
this.model = taskParams.getModel();
7776
this.poetExtensions = taskParams.getPoetExtensions();
7877
this.className = poetExtensions.getClientClass(model.getMetadata().getSyncClient());

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/SyncClientInterface.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
import software.amazon.awssdk.regions.ServiceMetadataProvider;
6363
import software.amazon.awssdk.regions.providers.DefaultAwsRegionProviderChain;
6464

65-
public final class SyncClientInterface implements ClassSpec {
65+
public class SyncClientInterface implements ClassSpec {
6666

6767
private final IntermediateModel model;
6868
private final ClassName className;

0 commit comments

Comments
 (0)