removing logging assertions for netty based transfer managers

Author: RanVaknin

services-custom/s3-transfer-manager/src/it/java/software/amazon/awssdk/transfer/s3/S3TransferManagerDownloadPauseResumeIntegrationTest.java

@@ -26,11 +26,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.time.Duration;
-import java.util.List;
 import java.util.Optional;
 import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.logging.log4j.Level;
-import org.apache.logging.log4j.core.LogEvent;
+import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -104,26 +103,31 @@ void pauseAndResume_ObjectEtagChange_shouldRestartDownload(S3TransferManager tm)
 
         String newEtag = putResponse.eTag();
         assertThat(newEtag).isNotEqualTo(originalEtag);
-        try (LogCaptor logCaptor = LogCaptor.create(Level.DEBUG)) {
 
+        boolean isCrtClient = tm.getClass().getName().contains("Crt");
+        if (isCrtClient) {
+            try (LogCaptor logCaptor = LogCaptor.create(Level.DEBUG)) {
+                FileDownload resumedFileDownload = tm.resumeDownloadFile(resumableFileDownload);
+                CompletedFileDownload completedDownload = resumedFileDownload.completionFuture().join();
+
+                assertThat(completedDownload.response().eTag()).isEqualTo(newEtag);
+                assertThat(testDownloadListener.transferInitiatedCount == 2).isTrue();
+
+                Assertions.assertThat(logCaptor.loggedEvents())
+                          .anySatisfy(logEvent -> Assertions.assertThat(logEvent.getMessage().getFormattedMessage())
+                                                            .contains(String.format("The ETag of the requested object in bucket (%s) with key (%s) "
+                                                                                    + "has changed since the last "
+                                                                                    + "pause. The SDK will download the S3 object from "
+                                                                                    + "the beginning",
+                                                                                    BUCKET, KEY)));
+            }
+        } else {
+            // skip the log assertion for Netty because DEBUG level will log the entire byte stream and crash codebuild
             FileDownload resumedFileDownload = tm.resumeDownloadFile(resumableFileDownload);
             CompletedFileDownload completedDownload = resumedFileDownload.completionFuture().join();
 
             assertThat(completedDownload.response().eTag()).isEqualTo(newEtag);
             assertThat(testDownloadListener.transferInitiatedCount == 2).isTrue();
-
-            List<LogEvent> logEvents = logCaptor.loggedEvents();
-            StringBuilder sb = new StringBuilder();
-            logEvents.forEach(logEvent -> {
-                sb.append(logEvent.getMessage().getFormattedMessage());
-            });
-
-            assertThat(sb)
-                .contains(String.format("The ETag of the requested object in bucket (%s) with key (%s) "
-                                        + "has changed since the last "
-                                        + "pause. The SDK will download the S3 object from "
-                                        + "the beginning",
-                                        BUCKET, KEY));
         }
     }