Skip to content

Commit 942e629

Browse files
committed
Add EnabledIf checks for ALPN tests
1 parent a7bee9b commit 942e629

File tree

3 files changed

+23
-14
lines changed

3 files changed

+23
-14
lines changed

http-clients/netty-nio-client/src/test/java/software/amazon/awssdk/http/nio/netty/NettyClientAlpnTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public void alpnClientJdkProvider_serverWithAlpnSupport_requestSucceeds() throws
6161
}
6262

6363
@Test
64+
@EnabledIf("alpnSupported")
6465
public void alpnClientOpenSslProvider_serverWithAlpnSupport_requestSucceeds() throws Exception {
6566
initClient(ProtocolNegotiation.ALPN, SslProvider.OPENSSL);
6667
initServer(true);
@@ -86,6 +87,7 @@ public void priorKnowledgeClient_serverWithAlpnSupport_requestSucceeds() throws
8687
}
8788

8889
@Test
90+
@EnabledIf("alpnSupported")
8991
public void priorKnowledgeClient_serverWithoutAlpnSupport_requestSucceeds() throws Exception {
9092
initClient(ProtocolNegotiation.ASSUME_PROTOCOL, SslProvider.JDK);
9193
initServer(false);

services/kinesis/src/it/java/software/amazon/awssdk/services/kinesis/AbstractTestCase.java

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
package software.amazon.awssdk.services.kinesis;
1717

18+
import io.netty.handler.ssl.SslProvider;
1819
import java.io.File;
1920
import java.io.FileInputStream;
2021
import java.io.IOException;
@@ -23,33 +24,21 @@
2324
import org.junit.jupiter.api.AfterAll;
2425
import org.junit.jupiter.api.BeforeAll;
2526
import software.amazon.awssdk.awscore.util.AwsHostNameUtils;
26-
import software.amazon.awssdk.http.Protocol;
27-
import software.amazon.awssdk.http.ProtocolNegotiation;
28-
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
27+
import software.amazon.awssdk.http.nio.netty.internal.utils.NettyUtils;
2928
import software.amazon.awssdk.regions.Region;
3029
import software.amazon.awssdk.testutils.service.AwsTestBase;
3130

3231
public class AbstractTestCase extends AwsTestBase {
3332
protected static KinesisClient client;
3433
protected static KinesisAsyncClient asyncClient;
35-
protected static KinesisAsyncClient asyncClientAlpn;
3634

3735
@BeforeAll
3836
public static void init() throws IOException {
3937
setUpCredentials();
4038
KinesisClientBuilder builder = KinesisClient.builder().credentialsProvider(CREDENTIALS_PROVIDER_CHAIN);
4139
setEndpoint(builder);
4240
client = builder.build();
43-
asyncClient = KinesisAsyncClient.builder()
44-
.credentialsProvider(CREDENTIALS_PROVIDER_CHAIN)
45-
.build();
46-
asyncClientAlpn = KinesisAsyncClient.builder()
47-
.httpClient(NettyNioAsyncHttpClient.builder()
48-
.protocol(Protocol.HTTP2)
49-
.protocolNegotiation(ProtocolNegotiation.ALPN)
50-
.build())
51-
.credentialsProvider(CREDENTIALS_PROVIDER_CHAIN)
52-
.build();
41+
asyncClient = kinesisAsyncClientBuilder().build();
5342
}
5443

5544
@AfterAll
@@ -58,6 +47,14 @@ public static void cleanUp() {
5847
asyncClient.close();
5948
}
6049

50+
protected static KinesisAsyncClientBuilder kinesisAsyncClientBuilder() {
51+
return KinesisAsyncClient.builder().credentialsProvider(CREDENTIALS_PROVIDER_CHAIN);
52+
}
53+
54+
protected static boolean alpnSupported(){
55+
return NettyUtils.isAlpnSupported(SslProvider.JDK);
56+
}
57+
6158
private static void setEndpoint(KinesisClientBuilder builder) throws IOException {
6259
File endpointOverrides = new File(
6360
new File(System.getProperty("user.home")),

services/kinesis/src/it/java/software/amazon/awssdk/services/kinesis/KinesisResponseMetadataIntegrationTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818
import static org.assertj.core.api.Assertions.assertThat;
1919

2020
import org.junit.jupiter.api.Test;
21+
import org.junit.jupiter.api.condition.EnabledIf;
22+
import software.amazon.awssdk.http.Protocol;
23+
import software.amazon.awssdk.http.ProtocolNegotiation;
24+
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
2125
import software.amazon.awssdk.services.kinesis.model.DescribeLimitsResponse;
2226
import software.amazon.awssdk.services.kinesis.model.KinesisResponse;
2327

@@ -36,7 +40,13 @@ public void async_shouldContainResponseMetadata() {
3640
}
3741

3842
@Test
43+
@EnabledIf("alpnSupported")
3944
public void asyncAlpn_shouldContainResponseMetadata() {
45+
KinesisAsyncClient asyncClientAlpn = kinesisAsyncClientBuilder().httpClient(NettyNioAsyncHttpClient.builder()
46+
.protocol(Protocol.HTTP2)
47+
.protocolNegotiation(ProtocolNegotiation.ALPN)
48+
.build())
49+
.build();
4050
DescribeLimitsResponse response = asyncClientAlpn.describeLimits().join();
4151
verifyResponseMetadata(response);
4252
}

0 commit comments

Comments
 (0)