updated after review

Author: joviegas

http-clients/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/Apache5ClientTlsAuthTest.java

@@ -291,7 +291,7 @@ public void tls_strategy_configuration() throws Exception {
     }
 
     @Test
-    public void testTlsStrategyOverridesLegacyFactory() throws Exception {
+    public void tls_strategy_overrides_legacy_factory() throws Exception {
         // Setup TLS context
         KeyManager[] keyManagers = keyManagersProvider.keyManagers();
         SSLContext sslContext = SSLContext.getInstance("TLS");
@@ -333,7 +333,7 @@ public void testTlsStrategyOverridesLegacyFactory() throws Exception {
     }
 
     @Test
-    public void testAdapterConvertsNonSslSocketException() throws Exception {
+    public void adapter_converts_non_sslSocketException() throws Exception {
         // Create mock that returns a regular Socket (not SSLSocket)
         SSLConnectionSocketFactory mockFactory = Mockito.mock(SSLConnectionSocketFactory.class);
         Socket nonSslSocket = Mockito.mock(Socket.class);
@@ -361,7 +361,7 @@ public void testAdapterConvertsNonSslSocketException() throws Exception {
 
 
     @Test
-    public void testAdapterHandlesNullSocket() throws Exception {
+    public void adapter_handlesNullSocket() throws Exception {
         // Create mock that returns null
         SSLConnectionSocketFactory mockFactory = Mockito.mock(SSLConnectionSocketFactory.class);
 
@@ -385,7 +385,7 @@ public void testAdapterHandlesNullSocket() throws Exception {
     }
 
     @Test
-    public void testNullTlsStrategyFallsBackToDefault() throws Exception {
+    public void null_tlsStrategy_falls_backToDefault() throws Exception {
         // Test that setting tlsSocketStrategy(null) works correctly
         client = Apache5HttpClient.builder()
                                   .tlsSocketStrategy(null)
@@ -395,6 +395,4 @@ public void testNullTlsStrategyFallsBackToDefault() throws Exception {
         HttpExecuteResponse response = makeRequestWithHttpClient(client);
         assertThat(response.httpResponse().isSuccessful()).isTrue();
     }
-
-
 }

http-clients/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/Apache5HttpClientTest.java

@@ -145,6 +145,4 @@ public InetAddress[] resolve(final String host) throws UnknownHostException {
                         .build()
                         .close();
     }
-
-
 }

http-clients/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/internal/conn/SdkTlsSocketFactoryTest.java

@@ -42,7 +42,7 @@ void nullProtocols() {
         when(socket.getSupportedProtocols()).thenReturn(null);
         when(socket.getEnabledProtocols()).thenReturn(null);
 
-        factory.initializeSocket(socket);  // Changed from prepareSocket
+        factory.initializeSocket(socket);
 
         verify(socket, never()).setEnabledProtocols(any());
     }
@@ -56,7 +56,7 @@ void amazonCorretto_8_0_292_defaultEnabledProtocols() {
             "TLSv1.2", "TLSv1.1", "TLSv1"
         });
 
-        factory.initializeSocket(socket);  // Changed from prepareSocket
+        factory.initializeSocket(socket);
 
         verify(socket, never()).setEnabledProtocols(any());
     }
@@ -70,7 +70,7 @@ void amazonCorretto_11_0_08_defaultEnabledProtocols() {
             "TLSv1.3", "TLSv1.2", "TLSv1.1", "TLSv1"
         });
 
-        factory.initializeSocket(socket);  // Changed from prepareSocket
+        factory.initializeSocket(socket);
 
         verify(socket, never()).setEnabledProtocols(any());
     }
@@ -84,7 +84,7 @@ void amazonCorretto_17_0_1_defaultEnabledProtocols() {
             "TLSv1.3", "TLSv1.2"
         });
 
-        factory.initializeSocket(socket);  // Changed from prepareSocket
+        factory.initializeSocket(socket);
 
         verify(socket, never()).setEnabledProtocols(any());
     }