Skip to content

Commit 96d0f62

Browse files
committed
Add tests for GeneratePresignedUrlRequest
1 parent 591e1cc commit 96d0f62

File tree

2 files changed

+8
-0
lines changed
  • test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven-nocompile

2 files changed

+8
-0
lines changed

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven-nocompile/after/src/main/java/foo/bar/S3Transforms.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import java.util.Date;
2323
import software.amazon.awssdk.core.async.AsyncRequestBody;
2424
import software.amazon.awssdk.services.s3.S3Client;
25+
import software.amazon.awssdk.services.s3.model.GeneratePresignedUrlRequest;
2526
import software.amazon.awssdk.services.s3.model.PutObjectRequest;
2627
import software.amazon.awssdk.transfer.s3.S3TransferManager;
2728
import software.amazon.awssdk.transfer.s3.model.UploadRequest;
@@ -45,5 +46,8 @@ private void generatePresignedUrl(S3Client s3, String bucket, String key, Date e
4546

4647
HttpMethod httpMethod = HttpMethod.PUT;
4748
URL urlWithHttpMethodVariable = /*AWS SDK for Java v2 migration: Transform for S3 generatePresignedUrl() with an assigned variable for HttpMethod is not supported. Update your code to pass in HttpMethod literal enum, or manually migrate your code.*/s3.generatePresignedUrl(bucket, key, expiration, httpMethod);
49+
50+
GeneratePresignedUrlRequest request = new GeneratePresignedUrlRequest(bucket, key);
51+
/*AWS SDK for Java v2 migration: Transforms are not supported for GeneratePresignedUrlRequest, please manually migrate your code.*/s3.generatePresignedUrl(request);
4852
}
4953
}

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven-nocompile/before/src/main/java/foo/bar/S3Transforms.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import com.amazonaws.HttpMethod;
1919
import com.amazonaws.services.s3.AmazonS3;
20+
import com.amazonaws.services.s3.model.GeneratePresignedUrlRequest;
2021
import com.amazonaws.services.s3.model.PutObjectRequest;
2122
import com.amazonaws.services.s3.transfer.TransferManager;
2223
import java.io.ByteArrayInputStream;
@@ -43,5 +44,8 @@ private void generatePresignedUrl(AmazonS3 s3, String bucket, String key, Date e
4344

4445
HttpMethod httpMethod = HttpMethod.PUT;
4546
URL urlWithHttpMethodVariable = s3.generatePresignedUrl(bucket, key, expiration, httpMethod);
47+
48+
GeneratePresignedUrlRequest request = new GeneratePresignedUrlRequest(bucket, key);
49+
s3.generatePresignedUrl(request);
4650
}
4751
}

0 commit comments

Comments
 (0)