Skip to content

Commit 9a0a2c8

Browse files
committed
Update comments
1 parent b87a023 commit 9a0a2c8

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven-nocompile/after/src/main/java/foo/bar/S3Transforms.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ private void generatePresignedUrl(S3Client s3, String bucket, String key, Date e
4545

4646

4747
HttpMethod httpMethod = HttpMethod.PUT;
48-
URL urlWithHttpMethodVariable = /*AWS SDK for Java v2 migration: Transform for S3 generatePresignedUrl() with an assigned variable for HttpMethod is not supported. Update your code to pass in enum instead and run the migration tool again, or manually migrate your code - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner/S3Presigner.html*/s3.generatePresignedUrl(bucket, key, expiration, httpMethod);
48+
URL urlWithHttpMethodVariable = /*AWS SDK for Java v2 migration: Transform for S3 generatePresignedUrl() with an assigned variable for HttpMethod is not supported. Please manually migrate your code - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner/S3Presigner.html*/s3.generatePresignedUrl(bucket, key, expiration, httpMethod);
4949

5050
GeneratePresignedUrlRequest request = new GeneratePresignedUrlRequest(bucket, key);
51-
/*AWS SDK for Java v2 migration: Transforms are not supported for GeneratePresignedUrlRequest, please manually migrate your code.- https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner/S3Presigner.html*/s3.generatePresignedUrl(request);
51+
/*AWS SDK for Java v2 migration: Transforms are not supported for GeneratePresignedUrlRequest, please manually migrate your code - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner/S3Presigner.html*/s3.generatePresignedUrl(request);
5252
}
5353
}

v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3NonStreamingRequestToV2Complex.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,9 @@ private J.MethodInvocation transformGeneratePresignedUrl(J.MethodInvocation meth
136136
return method.withComments(assignedVariableHttpMethodNotSupportedComment());
137137
}
138138

139-
String v2Method = String.format("S3Presigner.builder().s3Client(#{any()}).build()\n"
140-
+ ".presign%sObject(p -> p.%sObjectRequest(r -> r.bucket(#{any()}).key(#{any()}))\n"
141-
+ ".signatureDuration(Duration.between(Instant.now(), #{any()}.toInstant())))\n"
139+
String v2Method = String.format("S3Presigner.builder().s3Client(#{any()}).build()%n"
140+
+ ".presign%sObject(p -> p.%sObjectRequest(r -> r.bucket(#{any()}).key(#{any()}))%n"
141+
+ ".signatureDuration(Duration.between(Instant.now(), #{any()}.toInstant())))%n"
142142
+ ".url()",
143143
httpMethod, httpMethod.toLowerCase(Locale.ROOT));
144144

v2-migration/src/main/java/software/amazon/awssdk/v2migration/internal/utils/S3TransformUtils.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,13 @@ public static boolean isUnsupportedHttpMethod(String httpMethod) {
7979

8080
public static List<Comment> assignedVariableHttpMethodNotSupportedComment() {
8181
String comment = "Transform for S3 generatePresignedUrl() with an assigned variable for HttpMethod is not supported."
82-
+ " Update your code to pass in enum instead and run the migration tool again, or manually migrate "
83-
+ "your code - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner"
84-
+ "/S3Presigner.html";
82+
+ " Please manually migrate your code - https://sdk.amazonaws"
83+
+ ".com/java/api/latest/software/amazon/awssdk/services/s3/presigner/S3Presigner.html";
8584
return createComments(comment);
8685
}
8786

8887
public static List<Comment> requestPojoTransformNotSupportedComment() {
89-
String comment = "Transforms are not supported for GeneratePresignedUrlRequest, please manually migrate your code."
88+
String comment = "Transforms are not supported for GeneratePresignedUrlRequest, please manually migrate your code "
9089
+ "- https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/presigner"
9190
+ "/S3Presigner.html";
9291
return createComments(comment);

0 commit comments

Comments
 (0)