Addressing PR feedback

S-Saranya1 · S-Saranya1 · commit b66d7d95b987 · 2025-08-12T15:33:41.000-07:00
diff --git a/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/utils/ApacheUtils.java b/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/utils/ApacheUtils.java
@@ -155,12 +155,12 @@ private static void addPreemptiveAuthenticationProxy(HttpClientContext clientCon
             try {
                 basicAuth.processChallenge(new BasicHeader(AUTH.PROXY_AUTH, "BASIC realm=default"));
                 authCache.put(targetHost, basicAuth);
+                clientContext.setAuthCache(authCache);
             } catch (Exception e) {
                 logger.warn(() -> "Failed to process synthetic challenge for preemptive proxy authentication: " + e.getMessage());
             }
 
             clientContext.setCredentialsProvider(credsProvider);
-            clientContext.setAuthCache(authCache);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -155,12 +155,12 @@ private static void addPreemptiveAuthenticationProxy(HttpClientContext clientCon`
`155`	`155`	`try {`
`156`	`156`	`basicAuth.processChallenge(new BasicHeader(AUTH.PROXY_AUTH, "BASIC realm=default"));`
`157`	`157`	`authCache.put(targetHost, basicAuth);`
	`158`	`+ clientContext.setAuthCache(authCache);`
`158`	`159`	`} catch (Exception e) {`
`159`	`160`	`logger.warn(() -> "Failed to process synthetic challenge for preemptive proxy authentication: " + e.getMessage());`
`160`	`161`	`}`
`161`	`162`
`162`	`163`	`clientContext.setCredentialsProvider(credsProvider);`
`163`		`- clientContext.setAuthCache(authCache);`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`