Skip to content

Commit c4fbff2

Browse files
authored
Re-enable and fix tests (#3545)
1 parent c92b599 commit c4fbff2

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/resource/OutpostAccessPointArnEndpointResolutionTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,14 @@ public void outpostArn_dualstackEnabledViaClient_throwsIllegalArgumentException(
8686
}
8787

8888
@Test
89-
@Disabled // TODO: Renable once the FIPs pseudo region fix is merged into the branch
9089
public void outpostArn_fipsRegion_throwsIllegalArgumentException() throws Exception {
9190
mockHttpClient.stubNextResponse(mockListObjectsResponse());
9291
S3Client s3Client = clientBuilder().region(Region.of("fips-us-east-1")).serviceConfiguration(S3Configuration.builder().dualstackEnabled(false).build()).build();
9392
String outpostArn = "arn:aws:s3-outposts:us-east-1:123456789012:outpost:op-01234567890123456:accesspoint:myaccesspoint";
9493

9594
assertThatThrownBy(() -> s3Client.listObjects(ListObjectsRequest.builder().bucket(outpostArn).build()))
96-
.isInstanceOf(IllegalArgumentException.class)
97-
.hasMessageContaining("FIPS");
95+
.isInstanceOf(SdkClientException.class)
96+
.hasMessageContaining("S3 Outposts does not support FIPS");
9897
}
9998

10099
@Test

test/protocol-tests/src/test/java/software/amazon/awssdk/protocol/tests/endpoint/EndpointTraitTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ public void hostExpression_withoutInputMemberLabel() throws URISyntaxException {
9191
}
9292

9393
@Test
94-
@Ignore // TODO: fix with S3 endpoints 2.0 impl
9594
public void hostExpression_withInputMemberLabel() throws URISyntaxException {
9695
try {
9796
client.endpointTraitTwo(EndpointTraitTwoRequest.builder()

0 commit comments

Comments
 (0)