Remove def 16MB read chunk size (#5941)

* Remove def 16MB read chunk size

This commit removes the hardcoded 16MiB read chunk size for uploadFile()
in the TransferManager. This was originally a workaround to improve
performance when using CRT; however this is no longer necessary because
file uploads are done entirely in CRT without the SDK/Java layer doing
any reads.

Without this default size, the default read chunk size reverts back to
the default from `FileAsyncRequestBody` which is 16KiB.

* Fix test

Author: dagnir

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/GenericS3TransferManager.java

@@ -20,7 +20,6 @@
 import static software.amazon.awssdk.services.s3.multipart.S3MultipartExecutionAttribute.MULTIPART_DOWNLOAD_RESUME_CONTEXT;
 import static software.amazon.awssdk.services.s3.multipart.S3MultipartExecutionAttribute.PAUSE_OBSERVABLE;
 import static software.amazon.awssdk.services.s3.multipart.S3MultipartExecutionAttribute.RESUME_TOKEN;
-import static software.amazon.awssdk.transfer.s3.SizeConstant.MB;
 import static software.amazon.awssdk.transfer.s3.internal.utils.ResumableRequestConverter.toDownloadFileRequestAndTransformer;
 
 import java.util.Optional;
@@ -94,7 +93,6 @@
 
 @SdkInternalApi
 class GenericS3TransferManager implements S3TransferManager {
-    protected static final int DEFAULT_FILE_UPLOAD_CHUNK_SIZE = (int) (16 * MB);
     private static final Logger log = Logger.loggerFor(S3TransferManager.class);
     private static final PauseResumeHelper PAUSE_RESUME_HELPER = new PauseResumeHelper();
     private final S3AsyncClient s3AsyncClient;
@@ -180,7 +178,6 @@ public FileUpload uploadFile(UploadFileRequest uploadFileRequest) {
         AsyncRequestBody requestBody =
             FileAsyncRequestBody.builder()
                                 .path(uploadFileRequest.source())
-                                .chunkSizeInBytes(DEFAULT_FILE_UPLOAD_CHUNK_SIZE)
                                 .build();
 
         CompletableFuture<CompletedFileUpload> returnFuture = new CompletableFuture<>();

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/internal/S3JavaMultipartTransferProgressListenerTest.java

@@ -179,7 +179,7 @@ void listeners_reports_ErrorsWhenCancelled(boolean multipartEnabled) {
         assertMockOnFailure(transferListenerMock);
     }
 
-    @ParameterizedTest
+    @ParameterizedTest(name = "multipartEnabled = {0}")
     @ValueSource(booleans = {true, false})
     void listeners_reports_ProgressWhenSuccess(boolean multipartEnabled) {
         S3AsyncClient s3Async = s3AsyncClient(multipartEnabled);
@@ -209,7 +209,8 @@ void listeners_reports_ProgressWhenSuccess(boolean multipartEnabled) {
         Mockito.verify(transferListenerMock, times(1)).transferInitiated(ArgumentMatchers.any());
         Mockito.verify(transferListenerMock, times(1)).transferComplete(ArgumentMatchers.any());
 
-        int numTimesBytesTransferred = multipartEnabled ? 2 : 1;
+        // when false, the generic S3 TM will read 16KiB chunks, so OBJ_SIZE / 16KiB = 16MiB / 16KiB = 1024
+        int numTimesBytesTransferred = multipartEnabled ? 2 : 1024;
         Mockito.verify(transferListenerMock, times(numTimesBytesTransferred)).bytesTransferred(ArgumentMatchers.any());
     }