edited javadocs, added invalidurl test

Author: jencymaryjoseph

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/presignedurl/DefaultPresignedUrlManager.java

@@ -67,10 +67,7 @@ public DefaultPresignedUrlManager(SyncClientHandler clientHandler,
         this.clientConfiguration = clientConfiguration;
         this.protocolMetadata = protocolMetadata;
     }
-    
-    /**
-     * Downloads an S3 object using a presigned URL.
-     */
+
     @Override
     public <ReturnT> ReturnT getObject(PresignedUrlGetObjectRequest presignedUrlGetObjectRequest,
                                        ResponseTransformer<GetObjectResponse, ReturnT> responseTransformer) 

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/presignedurl/DefaultPresignedUrlManagerTest.java

@@ -31,6 +31,7 @@
 import org.junit.jupiter.params.provider.MethodSource;
 import org.mockito.ArgumentCaptor;
 import software.amazon.awssdk.awscore.retry.AwsRetryStrategy;
+import software.amazon.awssdk.core.exception.SdkClientException;
 import software.amazon.awssdk.metrics.MetricCollection;
 import software.amazon.awssdk.metrics.MetricPublisher;
 import software.amazon.awssdk.core.metrics.CoreMetric;
@@ -208,6 +209,23 @@ private static Stream<Arguments> additionalTestCases() {
         );
     }
 
+    private static Stream<Arguments> invalidUrlTestCases() {
+        return Stream.of(
+            Arguments.of(
+                "URL with spaces in path",
+                "https://test-bucket.s3.us-east-1.amazonaws.com/test key with spaces"
+            ),
+            Arguments.of(
+                "URL with invalid characters",
+                "https://test-bucket.s3.us-east-1.amazonaws.com/test<>key"
+            ),
+            Arguments.of(
+                "Malformed URL",
+                "not-a-valid-url"
+            )
+        );
+    }
+
     @ParameterizedTest(name = "{0}")
     @MethodSource("additionalTestCases")
     void given_PresignedUrlManager_when_ExecutingDifferentScenarios_then_ShouldBehaveCorrectly(String testName,
@@ -256,6 +274,21 @@ void given_PresignedUrlManager_when_ExecutingDifferentScenarios_then_ShouldBehav
         }
     }
 
+    @ParameterizedTest(name = "{0}")
+    @MethodSource("invalidUrlTestCases")
+    void given_PresignedUrlManager_when_GetObjectWithInvalidUrl_then_ShouldThrowException(String testName, String invalidUrlString) {
+        assertThatThrownBy(() -> {
+            URL invalidUrl = new URL(invalidUrlString);
+            PresignedUrlGetObjectRequest invalidRequest = PresignedUrlGetObjectRequest.builder()
+                                                                                     .presignedUrl(invalidUrl)
+                                                                                     .build();
+            presignedUrlManager.getObject(invalidRequest, ResponseTransformer.toInputStream());
+        }).satisfiesAnyOf(
+            ex -> assertThat(ex).isInstanceOf(java.net.MalformedURLException.class),
+            ex -> assertThat(ex).isInstanceOf(SdkClientException.class)
+        );
+    }
+
     private SdkClientConfiguration getDefaultSdkConfigs() {
         return SdkClientConfiguration.builder()
                                      .option(SdkClientOption.SYNC_HTTP_CLIENT, mockHttpClient)