java doc, logs

Author: L-Applin

utils/src/main/java/software/amazon/awssdk/utils/uri/SdkURI.java

@@ -18,6 +18,7 @@
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.Objects;
+import org.slf4j.event.Level;
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.utils.Logger;
 import software.amazon.awssdk.utils.cache.lru.LruCache;
@@ -132,11 +133,13 @@ private boolean isAccountIdUri(String s) {
     }
 
     private void logCacheUsage(boolean containsKey, URI uri) {
-        log.trace(() -> "URI cache size: " + cache.size());
-        if (containsKey) {
-            log.trace(() -> "Using cached uri for " + uri.toString());
-        } else {
-            log.trace(() -> "Cache empty for " + uri.toString());
+        if (log.isLoggingLevelEnabled(Level.TRACE)) {
+            log.trace(() -> "URI cache size: " + cache.size());
+            if (containsKey) {
+                log.trace(() -> "Using cached uri for " + uri.toString());
+            } else {
+                log.trace(() -> "Cache empty for " + uri.toString());
+            }
         }
     }
 

utils/src/main/java/software/amazon/awssdk/utils/uri/internal/UriConstructorArgs.java

@@ -18,7 +18,21 @@
 import java.net.URI;
 import software.amazon.awssdk.annotations.SdkInternalApi;
 
+/**
+ * Represent the different constructor to the URI class used by the SDK. Implementation of this interface are able to create new
+ * URIs based on the different arguments passed to classes to them.
+ *
+ * @see URI#create(String)
+ * @see URI#URI(String, String, String, String, String)
+ * @see URI#URI(String, String, String, int, String, String, String)
+ */
 @SdkInternalApi
 public interface UriConstructorArgs {
+
+    /**
+     * Creates a new instance of the URI. Can return a new instance everytime it is called.
+     *
+     * @return a new URI instance
+     */
     URI newInstance();
 }