Skip to content

Commit dff5595

Browse files
author
AWS
committed
Amazon CodeGuru Reviewer Update: Remove incorrect endpoint tests
1 parent 9ae8d2a commit dff5595

File tree

4 files changed

+32
-71
lines changed

4 files changed

+32
-71
lines changed

‎.changes/next-release/feature-AmazonCodeGuruReviewer-740ce6d.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "feature",
3+
"category": "Amazon CodeGuru Reviewer",
4+
"contributor": "",
5+
"description": "Remove incorrect endpoint tests"
6+
}

‎services/codegurureviewer/src/main/resources/codegen-resources/endpoint-rule-set.json‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
]
4141
}
4242
],
43-
"type": "tree",
4443
"rules": [
4544
{
4645
"conditions": [
@@ -83,7 +82,8 @@
8382
},
8483
"type": "endpoint"
8584
}
86-
]
85+
],
86+
"type": "tree"
8787
},
8888
{
8989
"conditions": [
@@ -96,7 +96,6 @@
9696
]
9797
}
9898
],
99-
"type": "tree",
10099
"rules": [
101100
{
102101
"conditions": [
@@ -110,7 +109,6 @@
110109
"assign": "PartitionResult"
111110
}
112111
],
113-
"type": "tree",
114112
"rules": [
115113
{
116114
"conditions": [
@@ -133,7 +131,6 @@
133131
]
134132
}
135133
],
136-
"type": "tree",
137134
"rules": [
138135
{
139136
"conditions": [
@@ -168,7 +165,6 @@
168165
]
169166
}
170167
],
171-
"type": "tree",
172168
"rules": [
173169
{
174170
"conditions": [],
@@ -179,14 +175,16 @@
179175
},
180176
"type": "endpoint"
181177
}
182-
]
178+
],
179+
"type": "tree"
183180
},
184181
{
185182
"conditions": [],
186183
"error": "FIPS and DualStack are enabled, but this partition does not support one or both",
187184
"type": "error"
188185
}
189-
]
186+
],
187+
"type": "tree"
190188
},
191189
{
192190
"conditions": [
@@ -200,14 +198,12 @@
200198
]
201199
}
202200
],
203-
"type": "tree",
204201
"rules": [
205202
{
206203
"conditions": [
207204
{
208205
"fn": "booleanEquals",
209206
"argv": [
210-
true,
211207
{
212208
"fn": "getAttr",
213209
"argv": [
@@ -216,11 +212,11 @@
216212
},
217213
"supportsFIPS"
218214
]
219-
}
215+
},
216+
true
220217
]
221218
}
222219
],
223-
"type": "tree",
224220
"rules": [
225221
{
226222
"conditions": [],
@@ -231,14 +227,16 @@
231227
},
232228
"type": "endpoint"
233229
}
234-
]
230+
],
231+
"type": "tree"
235232
},
236233
{
237234
"conditions": [],
238235
"error": "FIPS is enabled but this partition does not support FIPS",
239236
"type": "error"
240237
}
241-
]
238+
],
239+
"type": "tree"
242240
},
243241
{
244242
"conditions": [
@@ -252,7 +250,6 @@
252250
]
253251
}
254252
],
255-
"type": "tree",
256253
"rules": [
257254
{
258255
"conditions": [
@@ -272,7 +269,6 @@
272269
]
273270
}
274271
],
275-
"type": "tree",
276272
"rules": [
277273
{
278274
"conditions": [],
@@ -283,14 +279,16 @@
283279
},
284280
"type": "endpoint"
285281
}
286-
]
282+
],
283+
"type": "tree"
287284
},
288285
{
289286
"conditions": [],
290287
"error": "DualStack is enabled but this partition does not support DualStack",
291288
"type": "error"
292289
}
293-
]
290+
],
291+
"type": "tree"
294292
},
295293
{
296294
"conditions": [],
@@ -301,9 +299,11 @@
301299
},
302300
"type": "endpoint"
303301
}
304-
]
302+
],
303+
"type": "tree"
305304
}
306-
]
305+
],
306+
"type": "tree"
307307
},
308308
{
309309
"conditions": [],

‎services/codegurureviewer/src/main/resources/codegen-resources/endpoint-tests.json‎

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -273,17 +273,6 @@
273273
"UseDualStack": false
274274
}
275275
},
276-
{
277-
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack enabled",
278-
"expect": {
279-
"error": "FIPS and DualStack are enabled, but this partition does not support one or both"
280-
},
281-
"params": {
282-
"Region": "us-iso-east-1",
283-
"UseFIPS": true,
284-
"UseDualStack": true
285-
}
286-
},
287276
{
288277
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack disabled",
289278
"expect": {
@@ -297,17 +286,6 @@
297286
"UseDualStack": false
298287
}
299288
},
300-
{
301-
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack enabled",
302-
"expect": {
303-
"error": "DualStack is enabled but this partition does not support DualStack"
304-
},
305-
"params": {
306-
"Region": "us-iso-east-1",
307-
"UseFIPS": false,
308-
"UseDualStack": true
309-
}
310-
},
311289
{
312290
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack disabled",
313291
"expect": {
@@ -321,17 +299,6 @@
321299
"UseDualStack": false
322300
}
323301
},
324-
{
325-
"documentation": "For region us-isob-east-1 with FIPS enabled and DualStack enabled",
326-
"expect": {
327-
"error": "FIPS and DualStack are enabled, but this partition does not support one or both"
328-
},
329-
"params": {
330-
"Region": "us-isob-east-1",
331-
"UseFIPS": true,
332-
"UseDualStack": true
333-
}
334-
},
335302
{
336303
"documentation": "For region us-isob-east-1 with FIPS enabled and DualStack disabled",
337304
"expect": {
@@ -345,17 +312,6 @@
345312
"UseDualStack": false
346313
}
347314
},
348-
{
349-
"documentation": "For region us-isob-east-1 with FIPS disabled and DualStack enabled",
350-
"expect": {
351-
"error": "DualStack is enabled but this partition does not support DualStack"
352-
},
353-
"params": {
354-
"Region": "us-isob-east-1",
355-
"UseFIPS": false,
356-
"UseDualStack": true
357-
}
358-
},
359315
{
360316
"documentation": "For region us-isob-east-1 with FIPS disabled and DualStack disabled",
361317
"expect": {

‎services/codegurureviewer/src/main/resources/codegen-resources/service-2.json‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
"endpointPrefix":"codeguru-reviewer",
66
"jsonVersion":"1.1",
77
"protocol":"rest-json",
8+
"protocols":["rest-json"],
89
"serviceAbbreviation":"CodeGuruReviewer",
910
"serviceFullName":"Amazon CodeGuru Reviewer",
1011
"serviceId":"CodeGuru Reviewer",
1112
"signatureVersion":"v4",
1213
"signingName":"codeguru-reviewer",
13-
"uid":"codeguru-reviewer-2019-09-19"
14+
"uid":"codeguru-reviewer-2019-09-19",
15+
"auth":["aws.auth#sigv4"]
1416
},
1517
"operations":{
1618
"AssociateRepository":{
@@ -1155,8 +1157,7 @@
11551157
},
11561158
"PutRecommendationFeedbackResponse":{
11571159
"type":"structure",
1158-
"members":{
1159-
}
1160+
"members":{}
11601161
},
11611162
"Reaction":{
11621163
"type":"string",
@@ -1682,8 +1683,7 @@
16821683
},
16831684
"TagResourceResponse":{
16841685
"type":"structure",
1685-
"members":{
1686-
}
1686+
"members":{}
16871687
},
16881688
"TagValue":{
16891689
"type":"string",
@@ -1757,8 +1757,7 @@
17571757
},
17581758
"UntagResourceResponse":{
17591759
"type":"structure",
1760-
"members":{
1761-
}
1760+
"members":{}
17621761
},
17631762
"UserId":{
17641763
"type":"string",

0 commit comments

Comments
 (0)