Review comments

Author: dagnir

core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java

@@ -25,10 +25,10 @@
 import org.reactivestreams.Publisher;
 import org.reactivestreams.Subscriber;
 import software.amazon.awssdk.annotations.SdkInternalApi;
-import software.amazon.awssdk.http.auth.aws.internal.signer.io.ContentLengthAwareSubscriber;
 import software.amazon.awssdk.utils.Pair;
 import software.amazon.awssdk.utils.Validate;
 import software.amazon.awssdk.utils.async.AddingTrailingDataSubscriber;
+import software.amazon.awssdk.utils.async.ContentLengthAwareSubscriber;
 import software.amazon.awssdk.utils.async.DelegatingSubscriber;
 import software.amazon.awssdk.utils.async.FlatteningSubscriber;
 import software.amazon.awssdk.utils.internal.MappingSubscriber;

core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriber.java renamed to utils/src/main/java/software/amazon/awssdk/utils/async/ContentLengthAwareSubscriber.java

@@ -13,18 +13,18 @@
  * permissions and limitations under the License.
  */
 
-package software.amazon.awssdk.http.auth.aws.internal.signer.io;
+package software.amazon.awssdk.utils.async;
 
 import java.nio.ByteBuffer;
 import org.reactivestreams.Subscriber;
 import org.reactivestreams.Subscription;
-import software.amazon.awssdk.annotations.SdkInternalApi;
+import software.amazon.awssdk.annotations.SdkProtectedApi;
 
 /**
  * Decorator subscriber that limits the number of bytes sent to the wrapped subscriber to at most {@code contentLength}. Once
  * the given content length is reached, the upstream subscription is cancelled, and the wrapped subscriber is completed.
  */
-@SdkInternalApi
+@SdkProtectedApi
 public class ContentLengthAwareSubscriber implements Subscriber<ByteBuffer> {
     private final Subscriber<? super ByteBuffer> subscriber;
     private Subscription subscription;
@@ -53,7 +53,9 @@ public void onNext(ByteBuffer byteBuffer) {
             byteBuffer.limit(byteBuffer.position() + (int) bytesToRead);
             remaining -= bytesToRead;
             subscriber.onNext(byteBuffer);
-        } else if (remaining == 0 && !subscriptionCancelled) {
+        }
+
+        if (remaining == 0 && !subscriptionCancelled) {
             subscriptionCancelled = true;
             subscription.cancel();
             onComplete();

core/http-auth-aws/src/test/java/software/amazon/awssdk/http/auth/aws/PublisherUtils.java renamed to utils/src/test/java/software/amazon/awssdk/testutils/PublisherUtils.java

@@ -13,7 +13,7 @@
  * permissions and limitations under the License.
  */
 
-package software.amazon.awssdk.http.auth.aws;
+package software.amazon.awssdk.testutils;
 
 import io.reactivex.Flowable;
 import java.nio.ByteBuffer;

core/http-auth-aws/src/test/java/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriberTckTest.java renamed to utils/src/test/java/software/amazon/awssdk/utils/async/ContentLengthAwareSubscriberTckTest.java

@@ -13,7 +13,7 @@
  * permissions and limitations under the License.
  */
 
-package software.amazon.awssdk.http.auth.aws.internal.signer.io;
+package software.amazon.awssdk.utils.async;
 
 import io.reactivex.subscribers.TestSubscriber;
 import java.nio.ByteBuffer;

core/http-auth-aws/src/test/java/software/amazon/awssdk/http/auth/aws/internal/signer/io/ContentLengthAwareSubscriberTest.java renamed to utils/src/test/java/software/amazon/awssdk/utils/async/ContentLengthAwareSubscriberTest.java

@@ -13,10 +13,10 @@
  * permissions and limitations under the License.
  */
 
-package software.amazon.awssdk.http.auth.aws.internal.signer.io;
+package software.amazon.awssdk.utils.async;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static software.amazon.awssdk.http.auth.aws.PublisherUtils.randomPublisherOfLength;
+import static software.amazon.awssdk.testutils.PublisherUtils.randomPublisherOfLength;
 
 import io.reactivex.subscribers.TestSubscriber;
 import java.nio.ByteBuffer;