Do not retry NoSuchFileException and AccessDeniedException (#5470)

* Update ResponseTransformer so download attempts to a directory that does not exist or does not have write permissions are not retried

* Update ResponseTransformer so download attempts to a directory that does not exist or does not have write permissions are not retried

* Update ResponseTransformer so download attempts to a directory that does not exist or does not have write permissions are not retried

* Update ResponseTransformer so download attempts to a directory that does not exist or does not have write permissions are not retried

Author: davidh44

.changes/next-release/bugfix-AWSSDKforJavav2-353e392.json

@@ -0,0 +1,6 @@
+{
+    "type": "bugfix",
+    "category": "AWS SDK for Java v2",
+    "contributor": "",
+    "description": "Update ResponseTransformer so download attempts to a directory that does not exist or does not have write permissions are not retried"
+}

core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/ResponseTransformer.java

@@ -20,9 +20,11 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.nio.ByteBuffer;
+import java.nio.file.AccessDeniedException;
 import java.nio.file.DirectoryNotEmptyException;
 import java.nio.file.FileAlreadyExistsException;
 import java.nio.file.Files;
+import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.core.ResponseBytes;
@@ -108,8 +110,7 @@ static <ResponseT> ResponseTransformer<ResponseT, ResponseT> toFile(Path path) {
             } catch (IOException copyException) {
                 String copyError = "Failed to read response into file: " + path;
 
-                // If the write failed because of the state of the file, don't retry the request.
-                if (copyException instanceof FileAlreadyExistsException || copyException instanceof DirectoryNotEmptyException) {
+                if (shouldThrowIOException(copyException)) {
                     throw new IOException(copyError, copyException);
                 }
 
@@ -133,6 +134,17 @@ static <ResponseT> ResponseTransformer<ResponseT, ResponseT> toFile(Path path) {
         };
     }
 
+    /**
+     * If the write failed because of the state of the file, if the specified directory doesn't exist, or if the specified
+     * directory does not have write permissions, don't retry the request.
+     */
+    static boolean shouldThrowIOException(IOException copyException) {
+        return copyException instanceof FileAlreadyExistsException ||
+               copyException instanceof DirectoryNotEmptyException ||
+               copyException instanceof NoSuchFileException ||
+               copyException instanceof AccessDeniedException;
+    }
+
     /**
      * Creates a response transformer that writes all response content to the specified file. If the file already exists
      * then a {@link java.nio.file.FileAlreadyExistsException} will be thrown.

test/protocol-tests/src/test/java/software/amazon/awssdk/protocol/tests/ResponseTransformerTest.java

@@ -39,6 +39,7 @@
 import org.junit.Test;
 import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
 import software.amazon.awssdk.core.ResponseBytes;
+import software.amazon.awssdk.core.exception.RetryableException;
 import software.amazon.awssdk.core.exception.SdkClientException;
 import software.amazon.awssdk.core.sync.ResponseTransformer;
 import software.amazon.awssdk.http.apache.ApacheHttpClient;
@@ -103,17 +104,28 @@ public void downloadToFileRetriesCorrectly() throws IOException {
     }
 
     @Test
-    public void downloadToExistingFileDoesNotRetry() throws IOException {
+    public void downloadToExistingFileDoesNotRetry() {
         stubForRetriesTimeoutReadingFromStreams();
 
         assertThatThrownBy(() -> testClient().streamingOutputOperation(StreamingOutputOperationRequest.builder().build(),
             ResponseTransformer
                 .toFile(new File(".."))))
-            .isInstanceOf(SdkClientException.class);
+            .isInstanceOf(SdkClientException.class)
+            .isNotInstanceOf(RetryableException.class);
+    }
+
+    @Test
+    public void downloadToNonExistentDirectoryDoesNotRetry() {
+        stubForRetriesTimeoutReadingFromStreams();
+
+        assertThatThrownBy(() -> testClient().streamingOutputOperation(StreamingOutputOperationRequest.builder().build(),
+                                                                       ResponseTransformer.toFile(new File("/nonExistentDir/myFile"))))
+            .isInstanceOf(SdkClientException.class)
+            .isNotInstanceOf(RetryableException.class);
     }
 
     @Test
-    public void downloadToOutputStreamDoesNotRetry() throws IOException {
+    public void downloadToOutputStreamDoesNotRetry() {
         stubForRetriesTimeoutReadingFromStreams();
 
         assertThatThrownBy(() -> testClient().streamingOutputOperation(StreamingOutputOperationRequest.builder().build(),