Add fixture tests to cover binary handling edge cases

Author: RanVaknin

.changes/next-release/feature-AmazonDynamoDBEnhancedClient-798234c.json

@@ -2,5 +2,5 @@
     "type": "feature",
     "category": "Amazon DynamoDB Enhanced Client",
     "contributor": "",
-    "description": "Optimize implementation of the toJson() and getJson() used by the DDB Enhanced Client Serialization codepaths"
+    "description": "Optimize implementation of the `EnhancedDocument#toJson()` and `EnhancedDocument#getJson()`."
 }

services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/document/EnhancedDocumentTest.java

@@ -26,7 +26,11 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import java.io.IOException;
 import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
 import java.time.LocalDate;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -46,6 +50,7 @@
 import org.junit.jupiter.params.provider.ValueSource;
 import software.amazon.awssdk.core.SdkBytes;
 import software.amazon.awssdk.core.SdkNumber;
+import software.amazon.awssdk.enhanced.dynamodb.AttributeConverterProvider;
 import software.amazon.awssdk.enhanced.dynamodb.DefaultAttributeConverterProvider;
 import software.amazon.awssdk.enhanced.dynamodb.EnhancedType;
 import software.amazon.awssdk.enhanced.dynamodb.converters.document.CustomAttributeForDocumentConverterProvider;
@@ -679,4 +684,33 @@ void getJson_nonExistentAttribute() {
         assertThat(result).isNull();
     }
 
+    @Test
+    void toJson_fixtureFile_largeData() throws IOException {
+        String largeDataJson = new String(Files.readAllBytes(
+            Paths.get("src/test/resources/large_data_input.json")));
+
+        EnhancedDocument doc = EnhancedDocument.fromJson(largeDataJson);
+        String actualOutput = doc.toJson();
+
+        // This fixture file is generated after running legacy toJson()
+        String goldenOutput = new String(Files.readAllBytes(
+            Paths.get("src/test/resources/large_data_fixture.json")));
+
+        assertThat(actualOutput).isEqualTo(goldenOutput);
+    }
+
+    @Test
+    void toJson_fixtureFile_binaryEdgeCases() throws IOException {
+        String inputJson = new String(Files.readAllBytes(
+            Paths.get("src/test/resources/binary_edge_cases_input.json")), StandardCharsets.UTF_8);
+
+        EnhancedDocument doc = EnhancedDocument.fromJson(inputJson);
+        String actualOutput = doc.toJson();
+
+        // This fixture file is generated after running legacy toJson()
+        String goldenOutput = new String(Files.readAllBytes(
+            Paths.get("src/test/resources/binary_edge_cases_fixture.json")), StandardCharsets.UTF_8);
+
+        assertThat(actualOutput).isEqualTo(goldenOutput);
+    }
 }

services-custom/dynamodb-enhanced/src/test/resources/binary_edge_cases_fixture.json

@@ -0,0 +1 @@
+{"empty_bytes":"","one_byte":"AQ==","two_bytes":"AQI=","three_bytes":"AQID","four_bytes":"AQIDBA==","five_bytes":"AQIDBAU=","plus_slash_bytes":"++//","large_blob":"AQIDBAUGBwgJCgsMDQ4PEBESExQVFhcYGRobHB0eHyAhIiMkJSYnKCkqKywtLi8wMTIzNDU2Nzg5Ojs8PT4/QEFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaW1xdXl9gYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXp7fH1+fw==","bs_set":["AQ==","","AgME"],"nested":{"bytes_in_map":"AQIDBA=="},"list_with_bytes":["AQ==","AQI=","AQID"]}

services-custom/dynamodb-enhanced/src/test/resources/binary_edge_cases_input.json

@@ -0,0 +1,15 @@
+{
+  "empty_bytes": "",
+  "one_byte": "AQ==",
+  "two_bytes": "AQI=",
+  "three_bytes": "AQID",
+  "four_bytes": "AQIDBA==",
+  "five_bytes": "AQIDBAU=",
+  "plus_slash_bytes": "++//",
+  "large_blob": "AQIDBAUGBwgJCgsMDQ4PEBESExQVFhcYGRobHB0eHyAhIiMkJSYnKCkqKywtLi8wMTIzNDU2Nzg5Ojs8PT4/QEFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaW1xdXl9gYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXp7fH1+fw==",
+  "bs_set": ["AQ==", "", "AgME"],
+  "nested": {
+    "bytes_in_map": "AQIDBA=="
+  },
+  "list_with_bytes": ["AQ==", "AQI=", "AQID"]
+}