add functional test cases with wiremock and explicilty state that total attempts is 9

Author: joviegas

services/dynamodb/src/test/java/software/amazon/awssdk/services/dynamodb/DynamoDbDefaultRetryFunctionalTest.java

@@ -0,0 +1,110 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package software.amazon.awssdk.services.dynamodb;
+
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.anyUrl;
+import static com.github.tomakehurst.wiremock.client.WireMock.post;
+import static com.github.tomakehurst.wiremock.client.WireMock.stubFor;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+
+import com.github.tomakehurst.wiremock.junit5.WireMockRuntimeInfo;
+import com.github.tomakehurst.wiremock.junit5.WireMockTest;
+import java.net.URI;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
+import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
+import software.amazon.awssdk.core.SdkSystemSetting;
+import software.amazon.awssdk.regions.Region;
+import software.amazon.awssdk.services.dynamodb.model.DynamoDbException;
+import software.amazon.awssdk.testutils.EnvironmentVariableHelper;
+
+/**
+ * Functional tests to verify DynamoDB client retry behavior with different retry modes.
+ */
+@WireMockTest
+class DynamoDbDefaultRetryFunctionalTest {
+
+    private EnvironmentVariableHelper environmentVariableHelper;
+    private DynamoDbClient dynamoDbClient;
+
+    @BeforeEach
+    void setup(WireMockRuntimeInfo wm) {
+        environmentVariableHelper = new EnvironmentVariableHelper();
+
+        dynamoDbClient = DynamoDbClient.builder()
+                                       .endpointOverride(URI.create(wm.getHttpBaseUrl()))
+                                       .credentialsProvider(StaticCredentialsProvider.create(
+                                           AwsBasicCredentials.create("test", "test")))
+                                       .region(Region.US_EAST_1)
+                                       .build();
+    }
+
+    @AfterEach
+    void tearDown() {
+        environmentVariableHelper.reset();
+        if (dynamoDbClient != null) {
+            dynamoDbClient.close();
+        }
+    }
+
+    @Test
+    void listTables_whenNoRetryPolicySet_shouldAttempt9Times(WireMockRuntimeInfo wm) {
+        stubFor(post(anyUrl())
+                    .willReturn(aResponse().withStatus(503)));
+        assertThatExceptionOfType(DynamoDbException.class)
+            .isThrownBy(() -> dynamoDbClient.listTables());
+        int actualAttempts = wm.getWireMock().getAllServeEvents().size();
+        assertThat(actualAttempts)
+            .as("Default retry mode should result in 9 total attempts (1 initial + 8 retries)")
+            .isEqualTo(9);
+    }
+
+    @Test
+    void listTables_whenRetryModeSetToStandard_shouldAttempt10Times(WireMockRuntimeInfo wm) {
+        environmentVariableHelper.set(SdkSystemSetting.AWS_RETRY_MODE.environmentVariable(), "standard");
+        dynamoDbClient.close();
+        dynamoDbClient = DynamoDbClient.builder()
+                                       .endpointOverride(URI.create(wm.getHttpBaseUrl()))
+                                       .credentialsProvider(StaticCredentialsProvider.create(
+                                           AwsBasicCredentials.create("test", "test")))
+                                       .region(Region.US_EAST_1)
+                                       .build();
+        stubFor(post(anyUrl())
+                    .willReturn(aResponse().withStatus(503)));
+        assertThatExceptionOfType(DynamoDbException.class)
+            .isThrownBy(() -> dynamoDbClient.listTables());
+        int actualAttempts = wm.getWireMock().getAllServeEvents().size();
+        assertThat(actualAttempts)
+            .as("Standard retry mode should result in 9 total attempts (1 initial + 8 retries)")
+            .isEqualTo(9);
+    }
+
+    @Test
+    void listTables_whenUsingDefaultRetryMode_shouldAttempt9Times(WireMockRuntimeInfo wm) {
+        stubFor(post(anyUrl())
+                    .willReturn(aResponse().withStatus(503)));
+        assertThatExceptionOfType(DynamoDbException.class)
+            .isThrownBy(() -> dynamoDbClient.listTables());
+        int actualAttempts = wm.getWireMock().getAllServeEvents().size();
+        assertThat(actualAttempts)
+            .as("Default retry mode should result in 9 total attempts (1 initial + 8 retries)")
+            .isEqualTo(9);
+    }
+}

services/dynamodb/src/test/java/software/amazon/awssdk/services/dynamodb/DynamoDbRetryPolicyTest.java

@@ -126,4 +126,10 @@ void resolve_retryModeNotSetWithEnvNorSupplier_resolvesFromSdkDefault() {
         assertThat(retryMode).isEqualTo(RetryMode.STANDARD);
     }
 
+    @Test
+    void test_numRetries_with_defaultSettings() {
+        SdkClientConfiguration sdkClientConfiguration = SdkClientConfiguration.builder().build();
+        RetryStrategy retryStrategy = DynamoDbRetryPolicy.resolveRetryStrategy(sdkClientConfiguration);
+        assertThat(retryStrategy.maxAttempts()).isEqualTo(9);
+    }
 }