Add attemptNumber to sdk exceptions

[varming]

Describe the feature

When we get an sdk exception it can be difficult to figure out if the request was retried by the SDK. It would be really nice if the attemptNumber was copied into the sdk exception, so it is easy to see how many times a request was attempted.

Is your Feature Request related to a problem?

Understanding the SDK behavior in exceptional cases is often difficult. Adding more information to the sdk exception would make that simpler.

Proposed Solution

Add attemptNumber from

aws-sdk-java-v2/core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/http/pipeline/stages/utils/RetryableStageHelper.java

Line 61 in a321e63

private int attemptNumber = 0;

to sdk exceptions.

Describe alternatives you've considered

No response

Acknowledge

• I may be able to implement this feature request

AWS Java SDK version used

2.17.59

JDK version used

1.8.0_302

Operating System and version

Linux

[debora-ito]

@varming apologies for the delay in response.

If you enable the DEBUG level in the request logger, the attempt number will show up in the logs:

2021-11-08 11:32:42 [main] DEBUG software.amazon.awssdk.request:84 - Received error response: software.amazon.awssdk.services.s3.model.S3Exception: We encountered an internal error. Please try again. (Service: S3, Status Code: 200, Request ID: xxx, Extended Request ID: null)
2021-11-08 11:32:42 [main] DEBUG software.amazon.awssdk.request:95 - Retryable error detected. Will retry in 56ms. Request attempt number 2
software.amazon.awssdk.services.s3.model.S3Exception: We encountered an internal error. Please try again. (Service: S3, Status Code: 200, Request ID: xxx, Extended Request ID: null)
(...)

See how to enable the DEBUG level in "Request/response summary logging" - https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/logging-slf4j.html#sdk-java-logging-request-response

You can get even more insights on the application performance if you use Client-Side metrics, including retries - https://aws.amazon.com/blogs/developer/using-the-new-client-side-metrics-feature-in-the-aws-sdk-for-java-v2/

Let us know if this helps.

[varming]

With both debug level logs and client side metrics it is difficult to tie data from the log or metrics back to the specific exception thrown. It is fairly common for requests to be retried, so the stream of data is full of data about retries that did not cause an exception to be thrown by the client.

[joviegas]

#5834

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.