VersionedRecordExtension throws NumberFormatException for Long numbers

[tcerda95]

Describe the bug

VersionedRecordExtension uses Interger.parseInt to convert the attribute annotated with DynamoDbVersionAttribute from a String to a Integer.

This is wrong because you can annotate Longs with DynamoDbVersionAttribute. When such Long has a value that cannot be represented with an Integer, VersionedRecordExtension throws NumberFormatException.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

VersionedRecordExtension should not throw NumberFormatException for numbers that cannot be represent by an Integer such as 134117278857279131.

Current Behavior

When a Long attribute has a non-Integer representable value such as 134117278857279131L and is annotated with @DynamoDbVersionAttribute, then VersionedRecordExtension throws NumberFormatException

Reproduction Steps

@DynamoDbBean
public class Customer {
    private String id;
    private String name;
    private Long version;

    @DynamoDbPartitionKey
    public String getId() { return this.id; }

    public void setId(String id) { this.id = id; }

    public String getName() { return this.name; }

    public void setName(String name) { this.name = name; }

    @DynamoDbVersionAttribute
    public Long getVersion() { return this.version; }

    public void setVersion(Long version) { this.version = version; }
}

Customer customer = new Customer();
customer.setId("1");
customer.setName("CustomerName");
customer.setVersion(134117278857279131L);

// Throws NumberFormatException
customerTable.putItem(customer)

Possible Solution

Use Long.parseLong instead of Integer.parseInt in

aws-sdk-java-v2/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/extensions/VersionedRecordExtension.java

Line 126 in 9530396

int existingVersion = Integer.parseInt(existingVersionValue.get().n());

Additional Information/Context

No response

AWS Java SDK version used

2.29.17

JDK version used

21.0.4

Operating System and version

MacOs

[debora-ito]

@tcerda95 I see the issue, thank you for the report.

The fix will not be the simple one line change, I tested setting the value to 2147483647 (which is the Integer.MAX_VALUE) and the Enhanced Client will not update to 2147483647 + 1, it actually overflows to -2147483648, indicating that Long is not supported. The VersionAttribute write logic would need to change too, if we decide to support Long.

I'll discuss this case with the team, and will update here what we decide.

[debora-ito]

We are going to fix the support for Long attributes.

[debora-ito]

@tcerda95 looks like this issue was fixed when we added support for custom start and increment values (PR #6019) in SDK v.2.32.7.

Please test a version with the fix, and reach out if you have questions.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.