Skip to content

Add CrtS3TransferManager implementation of upload to support correct progress updates #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 15, 2025
Merged

Add CrtS3TransferManager implementation of upload to support correct progress updates #6341

merged 5 commits into from
Aug 15, 2025

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Aug 13, 2025 •
edited
Loading

Add CrtS3TransferManager implementation of upload to support correct progress updates.

Motivation and Context

see: #3670

When a non-file source (eg ByteBuffer/bytes[]) is used with the S3TransferManager.upload, the progress reported is inaccurate. This is because the TransferProgressUpdater.wrapRequestBody implementation reports progress when the bytes are read from the body rather than after they are sent on the wire.

Modifications

This PR adds a CRT specific implementation of the upload method that allows us to use the CRT progress listenter - this correctly reports progress on uploads.

Note - this does not address the bug in the Java S3TransferManager - doing so would require significant changes and rework of the ProgressUpdater and requires some mechanism to determine when bytes are actually sent - this likely would require additional event hooks be added to the HTTP client interface.

Testing

New and existing unit and integration tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods changed the title Add crt implementation of upload to support progress Add CrtS3TransferManager implementation of upload to support correct progress updates Aug 14, 2025
@alextwoods alextwoods marked this pull request as ready for review August 14, 2025 16:22
@alextwoods alextwoods requested a review from a team as a code owner August 14, 2025 16:22
@joviegas
Copy link
Contributor

Would it be possible to add an integration test that verifies the progress listener actually reports incremental progress (e.g., 0% → X% → X+Y% → X+Y+Z% → 100%) rather than jumping directly from 0% to 100%?
The unit test confirms the CRT listener is attached, but an integration test could validate the actual progress reporting behavior end-to-end and prevent regression of this issue.

@alextwoods
Copy link
Contributor Author

alextwoods commented Aug 14, 2025 •
edited
Loading

Yeah - that's a good idea but might be slightly tricky to get sure it's not flaky - let me see what I can do.

Edit: added a test that is similar to existing tests and should be reliable.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alextwoods alextwoods added this pull request to the merge queue Aug 15, 2025
Merged via the queue into master with commit 407d646 Aug 15, 2025
38 checks passed
@github-actions GitHub Actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextwoods @joviegas