From a2081cfb6e09c627faf996d8846a04916749a8f4 Mon Sep 17 00:00:00 2001 From: yibole Date: Wed, 13 Aug 2025 16:48:06 -0700 Subject: [PATCH 1/2] SdkException java doc changed --- .../software/amazon/awssdk/core/exception/SdkException.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java b/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java index 782a7b86adb2..2cca6a56779c 100644 --- a/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java +++ b/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java @@ -19,7 +19,8 @@ import software.amazon.awssdk.utils.builder.Buildable; /** - * Base class for all exceptions thrown by the SDK. + * Base class for SDK-specific exceptions. Note that underlying exceptions may be handled differently: + * IOExceptions are wrapped in UncheckedIOException. * * @see SdkServiceException * @see SdkClientException From 74f1f13c4ea92658060fa35474bd4604704da123 Mon Sep 17 00:00:00 2001 From: yibole Date: Wed, 13 Aug 2025 16:58:16 -0700 Subject: [PATCH 2/2] rephrase the javadoc --- .../software/amazon/awssdk/core/exception/SdkException.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java b/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java index 2cca6a56779c..e7891c02c62b 100644 --- a/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java +++ b/core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkException.java @@ -19,8 +19,9 @@ import software.amazon.awssdk.utils.builder.Buildable; /** - * Base class for SDK-specific exceptions. Note that underlying exceptions may be handled differently: - * IOExceptions are wrapped in UncheckedIOException. + * Base class for SDK-specific exceptions. Note that network operations may throw + * UncheckedIOException or propagate other RuntimeExceptions directly rather than wrapping + * them in SdkException. * * @see SdkServiceException * @see SdkClientException