-
Notifications
You must be signed in to change notification settings - Fork 936
Maven Central Migration #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Maven Central Migration #6375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes based on comments.
|
build: | ||
commands: | ||
- RELEASE_VERSION=`mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec` | ||
- ARTIFACT_URL="https://repo1.maven.org/maven2/software/amazon/awssdk/aws-sdk-java/$RELEASE_VERSION/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about this change. With OSSRH, we query the Nexus instance directly since there's a lag between publishing to the nexus instance and it being available through Maven (i.e. at https://repo1.maven.org
).
Is there a similar "pre-Maven" URL that we can hit for Central publishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a great question. I changed this to target the CDN because the existing polling endpoint "https://aws.oss.sonatype.org/service/local/repositories/releases/content/software/amazon/awssdk/aws-sdk-java/$RELEASE_VERSION/" is hosted on the nexus2 server. I was not sure if this will "go away" and if central will have it own server for hosting. I assume if it does happen the CDN will just get routed to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should keep it pointing to the oss endpoint?
This PR adds the needed configuration, profile, and buildspec needed to release to maven central.
central-portal-publishing
profile<name>
tags for the bom internal and archetype tools packages (required by maven central)bundle
andbundle-sdk
poms to be shaded.