Skip to content

Commit 0296d75

Browse files
authored
Remove type annotation transformation in redundant types (#618)
1 parent bf44354 commit 0296d75

File tree

3 files changed

+9
-38
lines changed

3 files changed

+9
-38
lines changed

.changeset/loud-rats-end.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": patch
3+
---
4+
5+
Remove type annotation transformation in redundant types

src/transforms/v2-to-v3/ts-type/replaceTSQualifiedName.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { DOCUMENT_CLIENT, DYNAMODB, DYNAMODB_DOCUMENT_CLIENT } from "../config";
44
import { getClientTypeNames } from "./getClientTypeNames";
55
import { getTSQualifiedNameFromClientName } from "./getTSQualifiedNameFromClientName";
66
import { getV3ClientType } from "./getV3ClientType";
7-
import { updateV2ClientType } from "./updateV2ClientType";
87

98
export interface ReplaceTSQualifiedNameOptions {
109
v2ClientName: string;
@@ -45,9 +44,9 @@ export const replaceTSQualifiedName = (
4544
(v2ClientType) =>
4645
isRightSectionIdentifier(v2ClientType.node) && !isParentTSQualifiedName(v2ClientType)
4746
)
48-
.forEach((v2ClientType) => {
47+
.replaceWith((v2ClientType) => {
4948
const v2ClientTypeName = getRightIdentifierName(v2ClientType.node);
50-
updateV2ClientType(j, v2ClientType, { ...clientTypeOptions, v2ClientTypeName });
49+
return getV3ClientType(j, { ...clientTypeOptions, v2ClientTypeName });
5150
});
5251
}
5352

@@ -68,9 +67,9 @@ export const replaceTSQualifiedName = (
6867
(v2ClientType) =>
6968
isRightSectionIdentifier(v2ClientType.node) && !isParentTSQualifiedName(v2ClientType)
7069
)
71-
.forEach((v2ClientType) => {
70+
.replaceWith((v2ClientType) => {
7271
const v2ClientTypeName = getRightIdentifierName(v2ClientType.node);
73-
updateV2ClientType(j, v2ClientType, { ...clientTypeOptions, v2ClientTypeName });
72+
return getV3ClientType(j, { ...clientTypeOptions, v2ClientTypeName });
7473
});
7574

7675
// Replace type reference to client type with modules.

src/transforms/v2-to-v3/ts-type/updateV2ClientType.ts

Lines changed: 0 additions & 33 deletions
This file was deleted.

0 commit comments

Comments
 (0)