Transform checks for error.code to error.name in callbacks (#820)

Author: trivikr

.changeset/four-pets-push.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Transform checks for error.code to error.name in callbacks

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.js

@@ -56,3 +56,15 @@ client
       }
     }
   );
+
+client.createBucket({ Bucket }, (error, response) => {
+  if (error) {
+    if (error.code === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      // Handle other error.
+    }
+  } else {
+    // Consume the response
+  }
+});

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.ts

@@ -63,3 +63,17 @@ export const funcPromiseCatchCallback = async (client: AWS.S3) => {
       }
     );
 }
+
+export const funcCallback = async (client: AWS.S3) => {
+  client.createBucket({ Bucket }, (error, response) => {
+    if (error) {
+      if (error.code === "BucketAlreadyExists") {
+        // Handle BucketAlreadyExists error
+      } else {
+        // Handle other error.
+      }
+    } else {
+      // Consume the response
+    }
+  });
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.js

@@ -53,3 +53,15 @@ client
       }
     }
   );
+
+client.createBucket({ Bucket }, (error, response) => {
+  if (error) {
+    if (error.name === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      // Handle other error.
+    }
+  } else {
+    // Consume the response
+  }
+});

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.ts

@@ -60,3 +60,17 @@ export const funcPromiseCatchCallback = async (client: S3) => {
       }
     );
 }
+
+export const funcCallback = async (client: S3) => {
+  client.createBucket({ Bucket }, (error, response) => {
+    if (error) {
+      if (error.name === "BucketAlreadyExists") {
+        // Handle BucketAlreadyExists error
+      } else {
+        // Handle other error.
+      }
+    } else {
+      // Consume the response
+    }
+  });
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.js

@@ -56,3 +56,15 @@ client
       }
     }
   );
+
+client.createBucket({ Bucket }, (error, response) => {
+  if (error) {
+    if (error.code === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      // Handle other error.
+    }
+  } else {
+    // Consume the response
+  }
+});

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.ts

@@ -63,3 +63,17 @@ export const funcPromiseCatchCallback = async (client: S3) => {
       }
     );
 }
+
+export const funcCallback = async (client: S3) => {
+  client.createBucket({ Bucket }, (error, response) => {
+    if (error) {
+      if (error.code === "BucketAlreadyExists") {
+        // Handle BucketAlreadyExists error
+      } else {
+        // Handle other error.
+      }
+    } else {
+      // Consume the response
+    }
+  });
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.js

@@ -53,4 +53,16 @@ client
       }
     }
   );
+
+client.createBucket({ Bucket }, (error, response) => {
+  if (error) {
+    if (error.name === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      // Handle other error.
+    }
+  } else {
+    // Consume the response
+  }
+});
 

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.ts

@@ -60,3 +60,17 @@ export const funcPromiseCatchCallback = async (client: S3) => {
       }
     );
 }
+
+export const funcCallback = async (client: S3) => {
+  client.createBucket({ Bucket }, (error, response) => {
+    if (error) {
+      if (error.name === "BucketAlreadyExists") {
+        // Handle BucketAlreadyExists error
+      } else {
+        // Handle other error.
+      }
+    } else {
+      // Consume the response
+    }
+  });
+}

src/transforms/v2-to-v3/apis/renameErrorCodeWithName.ts

@@ -129,5 +129,27 @@ export const renameErrorCodeWithName = (
 
         renameCodeWithName(j, j(failureCallbackFunction.body), errorParam.name);
       });
+
+    // Replace error.code with error.name in callbacks.
+    callExpressions.forEach((callExpression) => {
+      if (callExpression.value.arguments.length !== 2) {
+        return;
+      }
+
+      if (!FUNCTION_EXPRESSION_TYPES.includes(callExpression.value.arguments[1].type)) {
+        return;
+      }
+
+      const callbackFunction = callExpression.value.arguments[1] as
+        | FunctionExpression
+        | ArrowFunctionExpression;
+      const errorParam = callbackFunction.params[0];
+
+      if (errorParam?.type !== "Identifier") {
+        return;
+      }
+
+      renameCodeWithName(j, j(callbackFunction.body), errorParam.name);
+    });
   }
 };