fix: use 'as string' typecast for identifier.name

Author: trivikr

src/transforms/v2-to-v3/modules/importEqualsModule/getImportSpecifiers.ts

@@ -10,7 +10,7 @@ export const getImportSpecifiers = (
   const importSpecifiers = new Set<ImportSpecifierType>();
 
   getImportEqualsDeclarations(j, source, path).forEach((importEqualsDeclaration) => {
-    importSpecifiers.add({ localName: importEqualsDeclaration.value.id.name });
+    importSpecifiers.add({ localName: importEqualsDeclaration.value.id.name as string });
   });
 
   return Array.from(importSpecifiers);

src/transforms/v2-to-v3/modules/importEqualsModule/removeImportEquals.ts

@@ -7,7 +7,7 @@ const isAnotherSpecifier = (j: JSCodeshift, source: Collection<unknown>, localNa
 
 export const removeImportEquals = (j: JSCodeshift, source: Collection<unknown>) =>
   getImportEqualsDeclarations(j, source).forEach((importEqualsDeclaration) => {
-    const localName = importEqualsDeclaration.value.id.name;
+    const localName = importEqualsDeclaration.value.id.name as string;
     const identifiers = source.find(j.Identifier, { name: localName });
 
     // Either the identifier is the only occurence on the page.

src/transforms/v2-to-v3/modules/importModule/getImportSpecifiers.ts

@@ -14,17 +14,17 @@ export const getImportSpecifiers = (
     for (const specifier of specifiers) {
       switch (specifier.type) {
         case "ImportSpecifier": {
-          const importedName = specifier.imported.name;
+          const importedName = specifier.imported.name as string;
           importSpecifiers.add({
             importedName,
-            localName: specifier.local?.name || importedName,
+            localName: specifier.local?.name as string || importedName,
           });
           break;
         }
         case "ImportNamespaceSpecifier":
         case "ImportDefaultSpecifier": {
           if (specifier.local) {
-            importSpecifiers.add({ localName: specifier.local.name });
+            importSpecifiers.add({ localName: specifier.local.name as string });
           }
           break;
         }

src/transforms/v2-to-v3/modules/importModule/removeImport.ts

@@ -18,7 +18,7 @@ export const removeImport = (j: JSCodeshift, source: Collection<unknown>) =>
   getImportDeclarations(j, source).forEach((importDeclaration) => {
     importDeclaration.value.specifiers = (importDeclaration.value.specifiers || []).filter(
       (specifier) => {
-        const localName = specifier.local?.name;
+        const localName = specifier.local?.name as string;
         if (!localName) {
           return true;
         }

src/transforms/v2-to-v3/modules/importSpecifierCompareFn.ts

@@ -9,15 +9,20 @@ export const importSpecifierCompareFn = (
   specifier2: ImportSpecifier | ImportDefaultSpecifier | ImportNamespaceSpecifier
 ) => {
   if (specifier1.type === "ImportSpecifier" && specifier2.type === "ImportSpecifier") {
-    return specifier1.imported.name.localeCompare(specifier2.imported.name);
+    const specifier1ImportedName = specifier1.imported.name as string;
+    const specifier2ImportedName = specifier2.imported.name as string;
+    return specifier1ImportedName.localeCompare(specifier2ImportedName);
   }
 
+  const specifier1LocalName = specifier1.local?.name as string;
+  const specifier2LocalName = specifier2.local?.name as string;
+  
   if (
     specifier1.type === "ImportDefaultSpecifier" &&
     specifier2.type === "ImportDefaultSpecifier"
   ) {
     if (specifier1.local && specifier2.local)
-      return specifier1.local.name.localeCompare(specifier2.local.name);
+      return specifier1LocalName.localeCompare(specifier2LocalName);
     return 0;
   }
 
@@ -26,7 +31,7 @@ export const importSpecifierCompareFn = (
     specifier2.type === "ImportNamespaceSpecifier"
   ) {
     if (specifier1.local && specifier2.local)
-      return specifier1.local.name.localeCompare(specifier2.local.name);
+      return specifier1LocalName.localeCompare(specifier2LocalName);
     return 0;
   }
 

src/transforms/v2-to-v3/modules/objectPatternPropertyCompareFn.ts

@@ -2,6 +2,7 @@ import type {
   ObjectProperty,
   Property,
   PropertyPattern,
+  RestElement,
   RestProperty,
   SpreadProperty,
   SpreadPropertyPattern,
@@ -13,6 +14,7 @@ export type ObjectPatternProperty =
   | SpreadPropertyPattern
   | SpreadProperty
   | ObjectProperty
+  | RestElement
   | RestProperty;
 
 export const objectPatternPropertyCompareFn = (
@@ -26,7 +28,9 @@ export const objectPatternPropertyCompareFn = (
     return 0;
   }
   if (property1.key.type === "Identifier" && property2.key.type === "Identifier") {
-    return property1.key.name.localeCompare(property2.key.name);
+    const property1KeyName = property1.key.name as string;
+    const property2KeyName = property2.key.name as string;
+    return property1KeyName.localeCompare(property2KeyName);
   }
   return 0;
 };