Handle v2 client imports in case of ImportNamespaceSpecifier (#57)

Author: trivikr

.changeset/little-yaks-heal.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Handle v2 client imports in case of ImportNamespaceSpecifier

src/transforms/v2-to-v3/__fixtures__/clients-individual-star-import.input.ts

@@ -0,0 +1,3 @@
+import * as DynamoDB from "aws-sdk/clients/dynamodb";
+
+const client = new DynamoDB();

src/transforms/v2-to-v3/__fixtures__/clients-individual-star-import.output.ts

@@ -0,0 +1,3 @@
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const client = new DynamoDB();

src/transforms/v2-to-v3/utils/getV2ClientImportNames.ts

@@ -1,19 +1,26 @@
 import { Collection, JSCodeshift } from "jscodeshift";
-import findImports from "jscodeshift-find-imports";
 
 import { CLIENT_NAMES } from "./config";
 
 export const getV2ClientImportNames = (j: JSCodeshift, source: Collection<any>): string[] => {
   const v2ClientImportNames = [];
-  const { statement } = j.template;
 
   for (const clientName of CLIENT_NAMES) {
-    const importStatement = `import ${clientName} from 'aws-sdk/clients/${clientName.toLowerCase()}'`;
-    const imports = findImports(source, statement([importStatement]));
-
-    for (const importObj of Object.values(imports)) {
-      if (importObj.type === "Identifier") v2ClientImportNames.push(importObj.name);
-    }
+    // Add specifier name to v2ClientImportNames if it is imported in the source.
+    source
+      .find(j.ImportDeclaration, {
+        source: { value: `aws-sdk/clients/${clientName.toLowerCase()}` },
+      })
+      .forEach((declerationPath) => {
+        declerationPath.value.specifiers.forEach((specifier) => {
+          if (
+            specifier.type === "ImportDefaultSpecifier" ||
+            specifier.type === "ImportNamespaceSpecifier"
+          ) {
+            v2ClientImportNames.push(specifier.local.name);
+          }
+        });
+      });
   }
 
   return v2ClientImportNames;

src/transforms/v2-to-v3/utils/removeV2ClientImport.ts

@@ -10,17 +10,15 @@ export const removeV2ClientImport = (
     .find(j.ImportDeclaration, {
       specifiers: [
         {
-          type: "ImportDefaultSpecifier",
           local: { name: v2ClientName },
         },
       ],
       source: { value: importSourceName },
     })
     .forEach((declerationPath) => {
-      // Remove default import from ImportDeclaration.
+      // Remove import from ImportDeclaration.
       declerationPath.value.specifiers = declerationPath.value.specifiers.filter(
-        (specifier) =>
-          specifier.type !== "ImportDefaultSpecifier" && specifier.local.name !== v2ClientName
+        (specifier) => specifier.local.name !== v2ClientName
       );
       // Remove ImportDeclaration if there are no other imports.
       if (declerationPath.value.specifiers.length === 0) {