Enable eslint rule array-type with default 'array' (#91)

Author: trivikr

.changeset/friendly-kids-wash.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Enable eslint rule array-type with default 'array'

.eslintrc.json

@@ -5,7 +5,8 @@
   "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
   "rules": {
     "simple-import-sort/imports": "error",
-    "simple-import-sort/exports": "error"
+    "simple-import-sort/exports": "error",
+    "@typescript-eslint/array-type": ["error", { "default": "array" }]
   },
   "ignorePatterns": ["__fixtures__"]
 }

src/transforms/types.ts

@@ -2,7 +2,7 @@ export type PositionalOptionsType = "boolean" | "number" | "string";
 
 export interface AwsSdkJsCodemodTransformOption {
   /** array of values, limit valid option arguments to a predefined set */
-  choices?: ReadonlyArray<boolean> | ReadonlyArray<number> | ReadonlyArray<string>;
+  choices?: readonly boolean[] | readonly number[] | readonly string[];
 
   /** value, set a default value for the option */
   default?: boolean | number | string;

src/transforms/v2-to-v3/utils/getMergedArrayWithoutDuplicates.ts

@@ -1,2 +1,2 @@
-export const getMergedArrayWithoutDuplicates = <T>(arr1: Array<T>, arr2: Array<T>) =>
+export const getMergedArrayWithoutDuplicates = <T>(arr1: T[], arr2: T[]) =>
   arr1.concat(arr2.filter((arr2Item) => arr1.indexOf(arr2Item) < 0));

src/transforms/v2-to-v3/utils/getV2ClientNames.ts

@@ -11,7 +11,7 @@ export const getV2ClientNames = (
   j: JSCodeshift,
   source: Collection<any>,
   { v2DefaultModuleName, v2ClientModuleNames }: GetV2ClientNamesOptions
-): Array<string> => {
+): string[] => {
   const v2ClientNamesFromDefaultModule = source
     .find(j.NewExpression, {
       callee: {