Skip to content

Commit 5690340

Browse files
authored
Store 'aws-sdk' in constant PACKAGE_NAME (#75)
1 parent 34c3fb7 commit 5690340

File tree

7 files changed

+16
-5
lines changed

7 files changed

+16
-5
lines changed

.changeset/tidy-humans-search.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": patch
3+
---
4+
5+
Store 'aws-sdk' in constant PACKAGE_NAME

src/transforms/v2-to-v3/utils/addV3ClientImport.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Collection, JSCodeshift } from "jscodeshift";
22

33
import { AddV3ClientModuleOptions } from "./addV3ClientModule";
4+
import { PACKAGE_NAME } from "./config";
45

56
export const addV3ClientImport = (
67
j: JSCodeshift,
@@ -27,7 +28,7 @@ export const addV3ClientImport = (
2728
.find(j.ImportDeclaration)
2829
.filter(
2930
(path) =>
30-
path.value.source.value === "aws-sdk" ||
31+
path.value.source.value === PACKAGE_NAME ||
3132
path.value.source.value === `aws-sdk/clients/${v2ClientName.toLowerCase()}`
3233
)
3334
.insertAfter(

src/transforms/v2-to-v3/utils/addV3ClientRequire.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Collection, Identifier, JSCodeshift, ObjectPattern, Property } from "jscodeshift";
22

33
import { AddV3ClientModuleOptions } from "./addV3ClientModule";
4+
import { PACKAGE_NAME } from "./config";
45
import { getRequireVariableDeclaration } from "./getRequireVariableDeclaration";
56

67
export const addV3ClientRequire = (
@@ -42,7 +43,7 @@ export const addV3ClientRequire = (
4243

4344
// Insert after default require if present. If not, insert after client require.
4445
const clientRequireValue = `aws-sdk/clients/${v2ClientName.toLowerCase()}`;
45-
const defaultRequireVarDeclaration = getRequireVariableDeclaration(j, source, "aws-sdk");
46+
const defaultRequireVarDeclaration = getRequireVariableDeclaration(j, source, PACKAGE_NAME);
4647
const clientRequireVarDeclaration = getRequireVariableDeclaration(j, source, clientRequireValue);
4748

4849
const requireVarDeclaration =
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const PACKAGE_NAME = "aws-sdk";
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
export * from "./CLIENT_NAMES";
22
export * from "./CLIENT_NAMES_MAP";
33
export * from "./CLIENT_PACKAGE_NAMES_MAP";
4+
export * from "./constants";
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Collection, JSCodeshift } from "jscodeshift";
22

3+
import { PACKAGE_NAME } from "./config";
34
import { containsRequire } from "./containsRequire";
45
import { getImportIdentifierName } from "./getImportIdentifierName";
56
import { getRequireIdentifierName } from "./getRequireIdentifierName";
@@ -9,5 +10,5 @@ export const getV2DefaultModuleName = (
910
source: Collection<any>
1011
): string | undefined =>
1112
containsRequire(j, source)
12-
? getRequireIdentifierName(j, source, "aws-sdk")
13-
: getImportIdentifierName(j, source, "aws-sdk");
13+
? getRequireIdentifierName(j, source, PACKAGE_NAME)
14+
: getImportIdentifierName(j, source, PACKAGE_NAME);

src/transforms/v2-to-v3/utils/removeDefaultModuleIfNotUsed.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Collection, JSCodeshift } from "jscodeshift";
22

3+
import { PACKAGE_NAME } from "./config";
34
import { containsRequire } from "./containsRequire";
45
import { removeImportIdentifierName } from "./removeImportIdentifierName";
56
import { removeRequireIdentifierName } from "./removeRequireIdentifierName";
@@ -15,7 +16,7 @@ export const removeDefaultModuleIfNotUsed = (
1516
if (identifierUsages.size() === 1) {
1617
const removeIdentifierNameOptions = {
1718
identifierName: defaultModuleName,
18-
literalValue: "aws-sdk",
19+
literalValue: PACKAGE_NAME,
1920
};
2021
if (containsRequire(j, source)) {
2122
removeRequireIdentifierName(j, source, removeIdentifierNameOptions);

0 commit comments

Comments
 (0)