Skip to content

Commit 5fb11bb

Browse files
trivikrtrivikr
authored
Transform checks for error.code to error.name in promise catch (#810)
1 parent 242c9e8 commit 5fb11bb

File tree

10 files changed

+345
-57
lines changed

10 files changed

+345
-57
lines changed

‎.changeset/lemon-days-dress.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": patch
3+
---
4+
5+
Transform checks for error.code to error.name in promise catch

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.js

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,42 @@
11
import AWS from "aws-sdk";
22

33
const client = new AWS.S3();
4+
const Bucket = "bucket-name";
45

56
try {
6-
await client.createBucket({
7-
Bucket: "bucket"
8-
}).promise();
7+
await client.createBucket({ Bucket }).promise();
98
} catch (error) {
109
if (error.code === "BucketAlreadyExists") {
1110
// Handle BucketAlreadyExists error
1211
} else {
1312
throw error;
1413
}
15-
}
14+
}
15+
16+
client
17+
.createBucket({ Bucket })
18+
.promise()
19+
.then((response) => {
20+
// Consume the response
21+
})
22+
.catch((error) => {
23+
if (error.code === "BucketAlreadyExists") {
24+
// Handle BucketAlreadyExists error
25+
} else {
26+
// Handle other error.
27+
}
28+
});
29+
30+
client
31+
.createBucket({ Bucket })
32+
.promise()
33+
.then((response) => {
34+
// Consume the response
35+
})
36+
.catch(function (error) {
37+
if (error.code === "BucketAlreadyExists") {
38+
// Handle BucketAlreadyExists error
39+
} else {
40+
// Handle other error.
41+
}
42+
});

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.ts

Lines changed: 36 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,47 @@
11
import AWS from "aws-sdk";
22

3-
export const func = async (client: AWS.S3) => {
3+
const Bucket = "bucket-name";
4+
5+
export const funcTryCatch = async (client: AWS.S3) => {
46
try {
5-
await client.createBucket({
6-
Bucket: "bucket"
7-
}).promise();
7+
await client.createBucket({ Bucket }).promise();
88
} catch (error) {
99
if (error.code === "BucketAlreadyExists") {
1010
// Handle BucketAlreadyExists error
1111
} else {
1212
throw error;
1313
}
1414
}
15+
}
16+
17+
export const funcPromiseCatchArrowFn = async (client: AWS.S3) => {
18+
client
19+
.createBucket({ Bucket })
20+
.promise()
21+
.then((response) => {
22+
// Consume the response
23+
})
24+
.catch((error) => {
25+
if (error.code === "BucketAlreadyExists") {
26+
// Handle BucketAlreadyExists error
27+
} else {
28+
// Handle other error.
29+
}
30+
});
31+
}
32+
33+
export const funcPromiseCatchFn = async (client: AWS.S3) => {
34+
client
35+
.createBucket({ Bucket })
36+
.promise()
37+
.then((response) => {
38+
// Consume the response
39+
})
40+
.catch(function (error) {
41+
if (error.code === "BucketAlreadyExists") {
42+
// Handle BucketAlreadyExists error
43+
} else {
44+
// Handle other error.
45+
}
46+
});
1547
}

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.js

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,40 @@
11
import { S3 } from "@aws-sdk/client-s3";
22

33
const client = new S3();
4+
const Bucket = "bucket-name";
45

56
try {
6-
await client.createBucket({
7-
Bucket: "bucket"
8-
});
7+
await client.createBucket({ Bucket });
98
} catch (error) {
109
if (error.name === "BucketAlreadyExists") {
1110
// Handle BucketAlreadyExists error
1211
} else {
1312
throw error;
1413
}
15-
}
14+
}
15+
16+
client
17+
.createBucket({ Bucket })
18+
.then((response) => {
19+
// Consume the response
20+
})
21+
.catch((error) => {
22+
if (error.name === "BucketAlreadyExists") {
23+
// Handle BucketAlreadyExists error
24+
} else {
25+
// Handle other error.
26+
}
27+
});
28+
29+
client
30+
.createBucket({ Bucket })
31+
.then((response) => {
32+
// Consume the response
33+
})
34+
.catch(function (error) {
35+
if (error.name === "BucketAlreadyExists") {
36+
// Handle BucketAlreadyExists error
37+
} else {
38+
// Handle other error.
39+
}
40+
});

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.ts

Lines changed: 34 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,45 @@
11
import { S3 } from "@aws-sdk/client-s3";
22

3-
export const func = async (client: S3) => {
3+
const Bucket = "bucket-name";
4+
5+
export const funcTryCatch = async (client: S3) => {
46
try {
5-
await client.createBucket({
6-
Bucket: "bucket"
7-
});
7+
await client.createBucket({ Bucket });
88
} catch (error) {
99
if (error.name === "BucketAlreadyExists") {
1010
// Handle BucketAlreadyExists error
1111
} else {
1212
throw error;
1313
}
1414
}
15+
}
16+
17+
export const funcPromiseCatchArrowFn = async (client: S3) => {
18+
client
19+
.createBucket({ Bucket })
20+
.then((response) => {
21+
// Consume the response
22+
})
23+
.catch((error) => {
24+
if (error.name === "BucketAlreadyExists") {
25+
// Handle BucketAlreadyExists error
26+
} else {
27+
// Handle other error.
28+
}
29+
});
30+
}
31+
32+
export const funcPromiseCatchFn = async (client: S3) => {
33+
client
34+
.createBucket({ Bucket })
35+
.then((response) => {
36+
// Consume the response
37+
})
38+
.catch(function (error) {
39+
if (error.name === "BucketAlreadyExists") {
40+
// Handle BucketAlreadyExists error
41+
} else {
42+
// Handle other error.
43+
}
44+
});
1545
}

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.js

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,42 @@
11
import { S3 } from "aws-sdk";
22

33
const client = new S3();
4+
const Bucket = "bucket-name";
45

56
try {
6-
await client.createBucket({
7-
Bucket: "bucket"
8-
}).promise();
7+
await client.createBucket({ Bucket }).promise();
98
} catch (error) {
109
if (error.code === "BucketAlreadyExists") {
1110
// Handle BucketAlreadyExists error
1211
} else {
1312
throw error;
1413
}
15-
}
14+
}
15+
16+
client
17+
.createBucket({ Bucket })
18+
.promise()
19+
.then((response) => {
20+
// Consume the response
21+
})
22+
.catch((error) => {
23+
if (error.code === "BucketAlreadyExists") {
24+
// Handle BucketAlreadyExists error
25+
} else {
26+
// Handle other error.
27+
}
28+
});
29+
30+
client
31+
.createBucket({ Bucket })
32+
.promise()
33+
.then((response) => {
34+
// Consume the response
35+
})
36+
.catch(function (error) {
37+
if (error.code === "BucketAlreadyExists") {
38+
// Handle BucketAlreadyExists error
39+
} else {
40+
// Handle other error.
41+
}
42+
});

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.ts

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,47 @@
11
import { S3 } from "aws-sdk";
22

3+
const Bucket = "bucket-name";
4+
35
export const func = async (client: S3) => {
46
try {
5-
await client.createBucket({
6-
Bucket: "bucket"
7-
}).promise();
7+
await client.createBucket({ Bucket }).promise();
88
} catch (error) {
99
if (error.code === "BucketAlreadyExists") {
1010
// Handle BucketAlreadyExists error
1111
} else {
1212
throw error;
1313
}
1414
}
15+
}
16+
17+
export const funcPromiseCatchArrowFn = async (client: S3) => {
18+
client
19+
.createBucket({ Bucket })
20+
.promise()
21+
.then((response) => {
22+
// Consume the response
23+
})
24+
.catch((error) => {
25+
if (error.code === "BucketAlreadyExists") {
26+
// Handle BucketAlreadyExists error
27+
} else {
28+
// Handle other error.
29+
}
30+
});
31+
}
32+
33+
export const funcPromiseCatchFn = async (client: S3) => {
34+
client
35+
.createBucket({ Bucket })
36+
.promise()
37+
.then((response) => {
38+
// Consume the response
39+
})
40+
.catch(function (error) {
41+
if (error.code === "BucketAlreadyExists") {
42+
// Handle BucketAlreadyExists error
43+
} else {
44+
// Handle other error.
45+
}
46+
});
1547
}

‎src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.js

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,40 @@
11
import { S3 } from "@aws-sdk/client-s3";
22

33
const client = new S3();
4+
const Bucket = "bucket-name";
45

56
try {
6-
await client.createBucket({
7-
Bucket: "bucket"
8-
});
7+
await client.createBucket({ Bucket });
98
} catch (error) {
109
if (error.name === "BucketAlreadyExists") {
1110
// Handle BucketAlreadyExists error
1211
} else {
1312
throw error;
1413
}
15-
}
14+
}
15+
16+
client
17+
.createBucket({ Bucket })
18+
.then((response) => {
19+
// Consume the response
20+
})
21+
.catch((error) => {
22+
if (error.name === "BucketAlreadyExists") {
23+
// Handle BucketAlreadyExists error
24+
} else {
25+
// Handle other error.
26+
}
27+
});
28+
29+
client
30+
.createBucket({ Bucket })
31+
.then((response) => {
32+
// Consume the response
33+
})
34+
.catch(function (error) {
35+
if (error.name === "BucketAlreadyExists") {
36+
// Handle BucketAlreadyExists error
37+
} else {
38+
// Handle other error.
39+
}
40+
});

0 commit comments

Comments
 (0)