chore: remove type assertion in getWaiterConfig

Author: trivikr

src/transforms/v2-to-v3/apis/getWaiterConfig.ts

@@ -2,11 +2,8 @@ import type { ObjectExpression, ObjectProperty, Property } from "jscodeshift";
 
 import { OBJECT_PROPERTY_TYPE_LIST } from "../config";
 
-export const getWaiterConfig = (callArgument: unknown): ObjectExpression | undefined => {
-  if ((callArgument as ObjectExpression).type !== "ObjectExpression") {
-    return;
-  }
-  for (const property of (callArgument as ObjectExpression).properties) {
+export const getWaiterConfig = (originalConfig: ObjectExpression): ObjectExpression | undefined => {
+  for (const property of originalConfig.properties) {
     if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
       continue;
     }

src/transforms/v2-to-v3/apis/getWaiterConfigValue.ts

@@ -2,13 +2,7 @@ import type { ObjectExpression, ObjectProperty, Property } from "jscodeshift";
 
 import { OBJECT_PROPERTY_TYPE_LIST } from "../config";
 
-export const getWaiterConfigValue = (
-  waiterConfiguration: ObjectExpression | undefined,
-  key: string
-): string | undefined => {
-  if (!waiterConfiguration) {
-    return;
-  }
+export const getWaiterConfigValue = (waiterConfiguration: ObjectExpression, key: string) => {
   for (const property of waiterConfiguration.properties) {
     if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
       continue;
@@ -19,8 +13,15 @@ export const getWaiterConfigValue = (
       continue;
     }
     if (propertyKey.name === key) {
-      // @ts-expect-error value is Literal/StringLiteral
-      return propertyValue.value;
+      if (propertyValue.type === "Literal" || propertyValue.type === "StringLiteral") {
+        if (typeof propertyValue.value === "number") {
+          return propertyValue.value.toString();
+        }
+        if (typeof propertyValue.value === "string") {
+          return propertyValue.value;
+        }
+      }
+      return;
     }
   }
 };

src/transforms/v2-to-v3/apis/replaceWaiterApi.ts

@@ -21,9 +21,17 @@ export const replaceWaiterApi = (
       source
         .find(j.CallExpression, getClientWaiterCallExpression(clientId, waiterState))
         .replaceWith((callExpression) => {
-          const waiterConfig = getWaiterConfig(callExpression.node.arguments[1]);
-          const delay = getWaiterConfigValue(waiterConfig, "delay");
-          const maxAttempts = getWaiterConfigValue(waiterConfig, "maxAttempts");
+          let delay: string | undefined;
+          let maxAttempts: string | undefined;
+
+          const callArguments = callExpression.node.arguments;
+          if (callArguments.length > 1 && callArguments[0].type === "ObjectExpression") {
+            const waiterConfig = getWaiterConfig(callArguments[0]);
+            if (waiterConfig) {
+              delay = getWaiterConfigValue(waiterConfig, "delay");
+              maxAttempts = getWaiterConfigValue(waiterConfig, "maxAttempts");
+            }
+          }
 
           const properties = [];
           properties.push(