Skip to content

Commit 6344814

Browse files
authored
Replace TypeScript types created with imports (#289)
1 parent 086d1fd commit 6344814

10 files changed

+39
-18
lines changed

.changeset/young-cars-wash.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": patch
3+
---
4+
5+
Replace TypeScript types created with imports
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import AWS from "aws-sdk";
2+
3+
const testTags: AWS.S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import AWS_S3, { S3 } from "@aws-sdk/client-s3";
2+
3+
const testTags: AWS_S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import S3 from "aws-sdk/clients/s3";
2+
3+
const testTags: S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import AWS_S3, { S3 } from "@aws-sdk/client-s3";
2+
3+
const testTags: AWS_S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { S3 } from "aws-sdk";
2+
3+
const testTags: S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import AWS_S3, { S3 } from "@aws-sdk/client-s3";
2+
3+
const testTags: AWS_S3.Tag[] = [{ Key: "key", Value: "value" }];
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import { Collection, JSCodeshift } from "jscodeshift";
22

33
import { getV2ClientNamesFromNewExpr } from "./getV2ClientNamesFromNewExpr";
4-
import { getV2ClientNamesFromTSTypeRef } from "./getV2ClientNamesFromTSTypeRef";
4+
import { getV2ClientNamesFromTSQualifiedName } from "./getV2ClientNamesFromTSQualifiedName";
55

66
export const getV2ClientNamesFromGlobal = (
77
j: JSCodeshift,
88
source: Collection<unknown>,
99
v2GlobalName: string
1010
): string[] => {
1111
const namesFromNewExpr = getV2ClientNamesFromNewExpr(j, source, v2GlobalName);
12-
const namesFromTSTypeRef = getV2ClientNamesFromTSTypeRef(j, source, v2GlobalName);
13-
return [...new Set([...namesFromNewExpr, ...namesFromTSTypeRef])];
12+
const namesFromTSQualifiedName = getV2ClientNamesFromTSQualifiedName(j, source, v2GlobalName);
13+
return [...new Set([...namesFromNewExpr, ...namesFromTSQualifiedName])];
1414
};
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import { Collection, Identifier, JSCodeshift } from "jscodeshift";
2+
3+
export const getV2ClientNamesFromTSQualifiedName = (
4+
j: JSCodeshift,
5+
source: Collection<unknown>,
6+
v2GlobalName: string
7+
): string[] =>
8+
source
9+
.find(j.TSQualifiedName, {
10+
left: { name: v2GlobalName },
11+
})
12+
.nodes()
13+
.map((tsTypeReference) => (tsTypeReference.right as Identifier).name);

src/transforms/v2-to-v3/client-names/getV2ClientNamesFromTSTypeRef.ts

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)