Remove type assertion for Literal and StringLiteral

Author: trivikr

src/transforms/v2-to-v3/config/constants.ts

@@ -12,6 +12,5 @@ export const FUNCTION_TYPE_LIST = [
   "FunctionExpression",
   "ArrowFunctionExpression",
 ];
-export const STRING_LITERAL_TYPE_LIST = ["Literal", "StringLiteral"];
 
 export const NOT_SUPPORTED_COMMENT = "not supported in AWS SDK for JavaScript (v3)";

src/transforms/v2-to-v3/modules/requireModule/addNamedModule.ts

@@ -1,14 +1,6 @@
-import type {
-  Collection,
-  JSCodeshift,
-  Literal,
-  ObjectPattern,
-  ObjectProperty,
-  Property,
-  StringLiteral,
-} from "jscodeshift";
+import type { Collection, JSCodeshift, ObjectPattern, ObjectProperty, Property } from "jscodeshift";
 
-import { OBJECT_PROPERTY_TYPE_LIST, PACKAGE_NAME, STRING_LITERAL_TYPE_LIST } from "../../config";
+import { OBJECT_PROPERTY_TYPE_LIST, PACKAGE_NAME } from "../../config";
 import { objectPatternPropertyCompareFn } from "../objectPatternPropertyCompareFn";
 import { getRequireDeclarators } from "../requireModule";
 import type { ModulesOptions } from "../types";
@@ -73,11 +65,10 @@ export const addNamedModule = (
     })
     .filter((callExpression) => {
       const arg = callExpression.value.arguments[0];
-      if (!STRING_LITERAL_TYPE_LIST.includes(arg.type)) {
+      if (arg.type !== "Literal" && arg.type !== "StringLiteral") {
         return false;
       }
-      const argValue = (arg as Literal | StringLiteral).value;
-      return typeof argValue === "string" && argValue.startsWith(PACKAGE_NAME);
+      return typeof arg.value === "string" && arg.value.startsWith(PACKAGE_NAME);
     });
 
   if (v2RequireCallExpressions.size()) {

src/transforms/v2-to-v3/modules/requireModule/removeRequire.ts

@@ -3,14 +3,12 @@ import type {
   Collection,
   Identifier,
   JSCodeshift,
-  Literal,
   ObjectPattern,
   ObjectProperty,
   Property,
-  StringLiteral,
   VariableDeclarator,
 } from "jscodeshift";
-import { OBJECT_PROPERTY_TYPE_LIST, STRING_LITERAL_TYPE_LIST } from "../../config";
+import { OBJECT_PROPERTY_TYPE_LIST } from "../../config";
 import { removeDeclaration } from "../removeDeclaration";
 import type { ImportSpecifierType } from "../types";
 import { getRequireDeclarators } from "./getRequireDeclarators";
@@ -37,9 +35,9 @@ const isAnotherSpecifier = (j: JSCodeshift, source: Collection<unknown>, localNa
       const initArgs = init.arguments;
       if (!initArgs || initArgs.length !== 0) return false;
 
-      if (STRING_LITERAL_TYPE_LIST.includes(initArgs[0].type)) return false;
+      if (initArgs[0].type !== "Literal" && initArgs[0].type !== "StringLiteral") return false;
 
-      const sourceValue = (initArgs[0] as Literal | StringLiteral).value;
+      const sourceValue = initArgs[0].value;
       if (typeof sourceValue !== "string") return false;
       return sourceValue.startsWith("@aws-sdk/");
     })