Run linter on scripts folder (#912)

Author: trivikr

.github/workflows/build.yml

@@ -23,7 +23,7 @@ jobs:
       - name: install
         run: yarn
       - name: lint+format
-        run: biome ci src
+        run: biome ci
       - name: build
         run: yarn build
       - name: test

package.json

@@ -35,7 +35,7 @@
   "scripts": {
     "build": "tsc",
     "format": "biome format --write .",
-    "lint": "biome lint --write src",
+    "lint": "biome lint --write .",
     "release": "yarn build && changeset publish",
     "test": "vitest"
   },

scripts/generateClientTypesMap/getClientReqRespTypesMap.ts

@@ -1,8 +1,8 @@
 import jscodeshift, {
-  Identifier,
-  TSFunctionType,
-  TSQualifiedName,
-  TSTypeReference,
+  type Identifier,
+  type TSFunctionType,
+  type TSQualifiedName,
+  type TSTypeReference,
 } from "jscodeshift";
 
 import { getTypesSource } from "./getTypesSource";
@@ -35,7 +35,7 @@ export const getClientReqRespTypesMap = async (
       if (!params.typeAnnotation) return;
       if (!params.typeAnnotation.typeAnnotation) return;
       if (params.typeAnnotation.typeAnnotation.type !== "TSTypeReference") return;
-      const paramsTypeRef = params.typeAnnotation!.typeAnnotation! as TSTypeReference;
+      const paramsTypeRef = params.typeAnnotation.typeAnnotation as TSTypeReference;
 
       if (!paramsTypeRef.typeName) return;
       if (paramsTypeRef.typeName.type !== "TSQualifiedName") return;
@@ -55,7 +55,7 @@ export const getClientReqRespTypesMap = async (
       if (!callback.typeAnnotation) return;
       if (!callback.typeAnnotation.typeAnnotation) return;
       if (callback.typeAnnotation.typeAnnotation.type !== "TSFunctionType") return;
-      const callbackTypeRef = callback.typeAnnotation!.typeAnnotation! as TSFunctionType;
+      const callbackTypeRef = callback.typeAnnotation.typeAnnotation as TSFunctionType;
 
       if (!callbackTypeRef.parameters) return;
       if (callbackTypeRef.parameters.length !== 2) return;
@@ -66,7 +66,7 @@ export const getClientReqRespTypesMap = async (
       if (responseType.typeAnnotation.type !== "TSTypeAnnotation") return;
       if (!responseType.typeAnnotation.typeAnnotation) return;
       if (responseType.typeAnnotation.typeAnnotation.type !== "TSTypeReference") return;
-      const responseTypeRef = responseType.typeAnnotation!.typeAnnotation! as TSTypeReference;
+      const responseTypeRef = responseType.typeAnnotation.typeAnnotation as TSTypeReference;
 
       if (!responseTypeRef.typeName) return;
       if (responseTypeRef.typeName.type !== "TSQualifiedName") return;

scripts/generateClientTypesMap/getClientTypesMap.ts

@@ -1,4 +1,9 @@
-import jscodeshift, { Identifier, TSArrayType, TSTypeLiteral, TSTypeReference } from "jscodeshift";
+import jscodeshift, {
+  type Identifier,
+  type TSArrayType,
+  type TSTypeLiteral,
+  type TSTypeReference,
+} from "jscodeshift";
 
 import { CLIENT_NAMES_MAP, DOCUMENT_CLIENT } from "../../src/transforms/v2-to-v3/config";
 import { getClientTypesMapWithKeysRemovedFromValues } from "./getClientTypesMapWithKeysRemovedFromValues";

scripts/generateClientTypesMap/getTypesSource.ts

@@ -1,12 +1,12 @@
-import { readFileSync } from "fs";
-import { join } from "path";
-import { JSCodeshift } from "jscodeshift";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+import type { JSCodeshift } from "jscodeshift";
 import { DOCUMENT_CLIENT } from "../../src/transforms/v2-to-v3/config";
 
 export const getTypesSource = (j: JSCodeshift, clientName: string) => {
   const typesPath =
     clientName === DOCUMENT_CLIENT
-      ? join("node_modules", "aws-sdk", "lib", "dynamodb", `document_client.d.ts`)
+      ? join("node_modules", "aws-sdk", "lib", "dynamodb", "document_client.d.ts")
       : join("node_modules", "aws-sdk", "clients", `${clientName.toLowerCase()}.d.ts`);
   const relativeTypesPath = join(__dirname, "..", "..", typesPath);
 

scripts/generateClientTypesMap/index.ts

@@ -1,5 +1,5 @@
-import { writeFile } from "fs/promises";
-import { join } from "path";
+import { writeFile } from "node:fs/promises";
+import { join } from "node:path";
 import { format } from "prettier";
 
 import {
@@ -24,8 +24,8 @@ const codegenComment = `// This file is generated by scripts/generateClientTypes
 
     let fileContent = codegenComment;
 
-    fileContent += `\n\n/* eslint-disable @typescript-eslint/naming-convention */`;
-    fileContent += `\nexport const ${mapName}: Record<string, Record<string, string>> = `;
+    fileContent += "\n\n\n";
+    fileContent += `export const ${mapName}: Record<string, Record<string, string>> = `;
 
     const clientTypesMap = {};
 
@@ -37,7 +37,7 @@ const codegenComment = `// This file is generated by scripts/generateClientTypes
     }
 
     fileContent += JSON.stringify(clientTypesMap);
-    fileContent += `;\n`;
+    fileContent += ";\n";
 
     await writeFile(
       relativeFilePath,

scripts/generateNewClientTests/getGlobalImportEqualsInput.ts

@@ -2,10 +2,10 @@ import { CLIENTS_TO_TEST } from "./config";
 import { getV2ClientsNewExpressionCode } from "./getV2ClientsNewExpressionCode";
 
 export const getGlobalImportEqualsInput = () => {
-  let content = ``;
+  let content = "";
 
   content += `import AWS = require("aws-sdk");\n\n`;
-  content += getV2ClientsNewExpressionCode(CLIENTS_TO_TEST, `AWS.`);
+  content += getV2ClientsNewExpressionCode(CLIENTS_TO_TEST, "AWS.");
 
   return content;
 };

scripts/generateNewClientTests/getGlobalImportEqualsOutput.ts

@@ -4,7 +4,7 @@ import { getV3ClientsNewExpressionCode } from "./getV3ClientsNewExpressionCode";
 import { getV3PackageImportEqualsCode } from "./getV3PackageImportEqualsCode";
 
 export const getGlobalImportEqualsOutput = () => {
-  let content = ``;
+  let content = "";
 
   content += getV3PackageImportEqualsCode(getClientNamesSortedByPackageName(CLIENTS_TO_TEST));
   content += "\n";

scripts/generateNewClientTests/getGlobalImportInput.ts

@@ -2,10 +2,10 @@ import { CLIENT_NAMES } from "../../src/transforms/v2-to-v3/config";
 import { getV2ClientsNewExpressionCode } from "./getV2ClientsNewExpressionCode";
 
 export const getGlobalImportInput = () => {
-  let content = ``;
+  let content = "";
 
   content += `import AWS from "aws-sdk";\n\n`;
-  content += getV2ClientsNewExpressionCode(CLIENT_NAMES, `AWS.`);
+  content += getV2ClientsNewExpressionCode(CLIENT_NAMES, "AWS.");
 
   return content;
 };

scripts/generateNewClientTests/getGlobalImportOutput.ts

@@ -4,10 +4,10 @@ import { getV3ClientsNewExpressionCode } from "./getV3ClientsNewExpressionCode";
 import { getV3PackageImportsCode } from "./getV3PackageImportsCode";
 
 export const getGlobalImportOutput = () => {
-  let content = ``;
+  let content = "";
 
   content += getV3PackageImportsCode(getClientNamesSortedByPackageName(CLIENT_NAMES));
-  content += `\n`;
+  content += "\n";
   content += getV3ClientsNewExpressionCode(CLIENT_NAMES);
 
   return content;