Remove .promise() from client API calls (#29)

Author: trivikr

.changeset/smart-pots-yawn.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": minor
+---
+
+Remove .promise() from client API calls

src/transforms/v2-to-v3/__fixtures__/api-promise.input.ts

@@ -0,0 +1,11 @@
+import AWS from "aws-sdk";
+
+const region = "us-west-2";
+const client = new AWS.DynamoDB({ region });
+
+client
+  .listTables({})
+  .promise()
+  .then((data) => console.log(data))
+  .catch((err) => console.log(err, err.stack));
+

src/transforms/v2-to-v3/__fixtures__/api-promise.output.ts

@@ -0,0 +1,10 @@
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const region = "us-west-2";
+const client = new DynamoDB({ region });
+
+client
+  .listTables({})
+  .then((data) => console.log(data))
+  .catch((err) => console.log(err, err.stack));
+

src/transforms/v2-to-v3/transformer.ts

@@ -6,6 +6,7 @@ import {
   getV2ClientNames,
   getV2DefaultImportName,
   removeDefaultImportIfNotUsed,
+  removePromiseCalls,
   replaceClientCreation,
 } from "./utils";
 
@@ -24,11 +25,8 @@ export default function transformer(file: FileInfo, api: API) {
   for (const [v2ClientName, v3ClientMetadata] of Object.entries(clientMetadata).reverse()) {
     const { v3ClientName, v3ClientPackageName } = v3ClientMetadata;
     addV3ClientImport(j, source, { v3ClientName, v3ClientPackageName });
-    replaceClientCreation(j, source, {
-      v2DefaultImportName,
-      v2ClientName,
-      v3ClientName,
-    });
+    removePromiseCalls(j, source, { v2DefaultImportName, v2ClientName });
+    replaceClientCreation(j, source, { v2DefaultImportName, v2ClientName, v3ClientName });
   }
 
   removeDefaultImportIfNotUsed(j, source, v2DefaultImportName);

src/transforms/v2-to-v3/utils/index.ts

@@ -3,5 +3,6 @@ export * from "./getClientMetadata";
 export * from "./getV2ClientNames";
 export * from "./getV2DefaultImportName";
 export * from "./removeDefaultImportIfNotUsed";
+export * from "./removePromiseCalls";
 export * from "./replaceClientCreation";
 export * from "./types";

src/transforms/v2-to-v3/utils/removePromiseCalls.ts

@@ -0,0 +1,50 @@
+import { Collection, Identifier, JSCodeshift, MemberExpression } from "jscodeshift";
+
+export interface RemovePromiseCallsOptions {
+  v2ClientName: string;
+  v2DefaultImportName: string;
+}
+
+// Removes .promise() from client API calls.
+export const removePromiseCalls = (
+  j: JSCodeshift,
+  source: Collection<any>,
+  { v2DefaultImportName, v2ClientName }: RemovePromiseCallsOptions
+): void => {
+  source
+    .find(j.VariableDeclarator, {
+      id: { type: "Identifier" },
+      init: {
+        type: "NewExpression",
+        callee: {
+          object: { type: "Identifier", name: v2DefaultImportName },
+          property: { type: "Identifier", name: v2ClientName },
+        },
+      },
+    })
+    .forEach((nodePath) => {
+      const name = (nodePath.value.id as Identifier).name;
+      source
+        .find(j.CallExpression, {
+          callee: {
+            type: "MemberExpression",
+            object: {
+              type: "CallExpression",
+              callee: {
+                type: "MemberExpression",
+                object: {
+                  type: "Identifier",
+                  name,
+                },
+              },
+            },
+            property: { type: "Identifier", name: "promise" },
+          },
+        })
+        .forEach((callExpressionPath) => {
+          callExpressionPath.parentPath.value.object = (
+            callExpressionPath.value.callee as MemberExpression
+          ).object;
+        });
+    });
+};