Filter client names received from new expressions and TS Types (#329)

Author: trivikr

.changeset/shaggy-jobs-hide.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Filter client names received from new expressions and TS Types

src/transforms/v2-to-v3/__fixtures__/misc/unsupported-feature.input.js

@@ -0,0 +1,5 @@
+// ToDo: Update when transformation is added.
+// Current test verifies error is not thrown.
+import AWS from "aws-sdk";
+
+const credentials = new AWS.SharedIniFileCredentials({ profile: "my-profile" });

src/transforms/v2-to-v3/__fixtures__/misc/unsupported-feature.output.js

@@ -0,0 +1,5 @@
+// ToDo: Update when transformation is added.
+// Current test verifies error is not thrown.
+import AWS from "aws-sdk";
+
+const credentials = new AWS.SharedIniFileCredentials({ profile: "my-profile" });

src/transforms/v2-to-v3/client-names/getV2ClientNamesFromNewExpr.ts renamed to src/transforms/v2-to-v3/client-names/getNamesFromNewExpr.ts

@@ -2,7 +2,7 @@ import { Collection, Identifier, JSCodeshift, MemberExpression } from "jscodeshi
 
 import { getV2ClientNewExpression } from "../utils";
 
-export const getV2ClientNamesFromNewExpr = (
+export const getNamesFromNewExpr = (
   j: JSCodeshift,
   source: Collection<unknown>,
   v2GlobalName: string

src/transforms/v2-to-v3/client-names/getV2ClientNamesFromTSQualifiedName.ts renamed to src/transforms/v2-to-v3/client-names/getNamesFromTSQualifiedName.ts

@@ -1,6 +1,6 @@
 import { Collection, Identifier, JSCodeshift } from "jscodeshift";
 
-export const getV2ClientNamesFromTSQualifiedName = (
+export const getNamesFromTSQualifiedName = (
   j: JSCodeshift,
   source: Collection<unknown>,
   v2GlobalName: string

src/transforms/v2-to-v3/client-names/getV2ClientNamesFromGlobal.ts

@@ -1,14 +1,18 @@
 import { Collection, JSCodeshift } from "jscodeshift";
 
-import { getV2ClientNamesFromNewExpr } from "./getV2ClientNamesFromNewExpr";
-import { getV2ClientNamesFromTSQualifiedName } from "./getV2ClientNamesFromTSQualifiedName";
+import { CLIENT_NAMES } from "../config";
+import { getNamesFromNewExpr } from "./getNamesFromNewExpr";
+import { getNamesFromTSQualifiedName } from "./getNamesFromTSQualifiedName";
 
 export const getV2ClientNamesFromGlobal = (
   j: JSCodeshift,
   source: Collection<unknown>,
   v2GlobalName: string
 ): string[] => {
-  const namesFromNewExpr = getV2ClientNamesFromNewExpr(j, source, v2GlobalName);
-  const namesFromTSQualifiedName = getV2ClientNamesFromTSQualifiedName(j, source, v2GlobalName);
-  return [...new Set([...namesFromNewExpr, ...namesFromTSQualifiedName])];
+  const namesFromNewExpr = getNamesFromNewExpr(j, source, v2GlobalName);
+  const namesFromTSQualifiedName = getNamesFromTSQualifiedName(j, source, v2GlobalName);
+
+  return [...new Set([...namesFromNewExpr, ...namesFromTSQualifiedName])].filter((name) =>
+    CLIENT_NAMES.includes(name)
+  );
 };