Add tests for named imports with local name (#338)

Author: trivikr

scripts/generateNewClientTests/config.ts

@@ -1 +1,3 @@
 export const CLIENTS_TO_TEST = ["ACM", "AccessAnalyzer", "Discovery"];
+
+export const LOCAL_NAME_SUFFIX = "Client";

scripts/generateNewClientTests/getServiceImportWithNameInput.ts

@@ -0,0 +1,16 @@
+import { CLIENTS_TO_TEST, LOCAL_NAME_SUFFIX } from "./config";
+import { getV2ClientsNewExpressionCode } from "./getV2ClientsNewExpressionCode";
+
+export const getServiceImportWithNameInput = (codegenComment: string) => {
+  let serviceImportInputContent = `${codegenComment}\n`;
+
+  serviceImportInputContent += `import { \n${CLIENTS_TO_TEST.map(
+    (clientName) => `  ${clientName} as ${clientName}${LOCAL_NAME_SUFFIX}`
+  ).join(`,\n`)}\n} from "aws-sdk";\n`;
+  serviceImportInputContent += `\n`;
+  serviceImportInputContent += getV2ClientsNewExpressionCode(
+    CLIENTS_TO_TEST.map((clientName) => `${clientName}${LOCAL_NAME_SUFFIX}`)
+  );
+
+  return serviceImportInputContent;
+};

scripts/generateNewClientTests/getServiceImportWithNameOutput.ts

@@ -0,0 +1,23 @@
+import { CLIENT_NAMES_MAP, CLIENT_PACKAGE_NAMES_MAP } from "../../src/transforms/v2-to-v3/config";
+import { CLIENTS_TO_TEST, LOCAL_NAME_SUFFIX } from "./config";
+import { getClientNamesSortedByPackageName } from "./getClientNamesSortedByPackageName";
+import { getV3ClientsNewExpressionCode } from "./getV3ClientsNewExpressionCode";
+
+export const getServiceImportWithNameOutput = (codegenComment: string) => {
+  let serviceImportOutputContent = `${codegenComment}\n`;
+
+  for (const v2ClientName of getClientNamesSortedByPackageName(CLIENTS_TO_TEST)) {
+    const v3ClientName = CLIENT_NAMES_MAP[v2ClientName];
+    const v3ClientPackageName = `@aws-sdk/${CLIENT_PACKAGE_NAMES_MAP[v2ClientName]}`;
+    const v3ClientLocalName = `${v2ClientName}${LOCAL_NAME_SUFFIX}`;
+    const v3ImportSpecifier =
+      v3ClientName === v3ClientLocalName ? v3ClientName : `${v3ClientName} as ${v3ClientLocalName}`;
+    serviceImportOutputContent += `import { ${v3ImportSpecifier} } from "${v3ClientPackageName}";\n`;
+  }
+  serviceImportOutputContent += `\n`;
+  serviceImportOutputContent += getV3ClientsNewExpressionCode(
+    CLIENTS_TO_TEST.map((clientName) => `${clientName}${LOCAL_NAME_SUFFIX}`)
+  );
+
+  return serviceImportOutputContent;
+};

scripts/generateNewClientTests/index.ts

@@ -15,6 +15,8 @@ import { getServiceImportEqualsInput } from "./getServiceImportEqualsInput";
 import { getServiceImportEqualsOutput } from "./getServiceImportEqualsOutput";
 import { getServiceImportInput } from "./getServiceImportInput";
 import { getServiceImportOutput } from "./getServiceImportOutput";
+import { getServiceImportWithNameInput } from "./getServiceImportWithNameInput";
+import { getServiceImportWithNameOutput } from "./getServiceImportWithNameOutput";
 import { getServiceRequireDeepInput } from "./getServiceRequireDeepInput";
 import { getServiceRequireDeepOutput } from "./getServiceRequireDeepOutput";
 import { getServiceRequireInput } from "./getServiceRequireInput";
@@ -44,6 +46,8 @@ const newClientTestsPath = join(__dirname, "..", "..", newClientsTestsFolder);
     ["service-import-equals.output.ts", getServiceImportEqualsOutput],
     ["service-import-deep.input.js", getServiceImportDeepInput],
     ["service-import-deep.output.js", getServiceImportDeepOutput],
+    ["service-import-with-name.input.js", getServiceImportWithNameInput],
+    ["service-import-with-name.output.js", getServiceImportWithNameOutput],
     ["service-require.input.js", getServiceRequireInput],
     ["service-require.output.js", getServiceRequireOutput],
     ["service-require-deep.input.js", getServiceRequireDeepInput],

src/transforms/v2-to-v3/__fixtures__/new-client/service-import-with-name.input.js

@@ -0,0 +1,12 @@
+// This file is generated by scripts/generateNewClientTests/index.ts
+// Do not edit this file directly. Instead, edit the script and run it to regenerate this file.
+"use strict";
+import { 
+  ACM as ACMClient,
+  AccessAnalyzer as AccessAnalyzerClient,
+  Discovery as DiscoveryClient
+} from "aws-sdk";
+
+new ACMClient();
+new AccessAnalyzerClient();
+new DiscoveryClient();

src/transforms/v2-to-v3/__fixtures__/new-client/service-import-with-name.output.js

@@ -0,0 +1,10 @@
+// This file is generated by scripts/generateNewClientTests/index.ts
+// Do not edit this file directly. Instead, edit the script and run it to regenerate this file.
+"use strict";
+import { AccessAnalyzer as AccessAnalyzerClient } from "@aws-sdk/client-accessanalyzer";
+import { ACM as ACMClient } from "@aws-sdk/client-acm";
+import { ApplicationDiscoveryService as DiscoveryClient } from "@aws-sdk/client-application-discovery-service";
+
+new ACMClient();
+new AccessAnalyzerClient();
+new DiscoveryClient();