Skip to content

Commit ca4eb56

Browse files
authored
chore: drop support for Node.js 12.x (#132)
1 parent b890648 commit ca4eb56

13 files changed

+33
-26
lines changed

.changeset/large-seals-rush.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": minor
3+
---
4+
5+
Drop support for Node.js 12.x

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [12.x]
12+
node-version: [14.x, 16.x, 18.x]
1313

1414
steps:
1515
- uses: actions/checkout@v2

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
},
4545
"devDependencies": {
4646
"@changesets/cli": "2.21.0",
47-
"@tsconfig/node12": "1.0.2",
47+
"@tsconfig/node14": "1.0.3",
4848
"@types/jest": "27.4.1",
4949
"@types/jscodeshift": "0.11.5",
50-
"@types/node": "16.11.26",
50+
"@types/node": "14.18.33",
5151
"@typescript-eslint/eslint-plugin": "5.43.0",
5252
"@typescript-eslint/parser": "5.43.0",
5353
"eslint": "8.27.0",
@@ -60,7 +60,7 @@
6060
"typescript": "4.8.4"
6161
},
6262
"engines": {
63-
"node": ">=12.0.0"
63+
"node": ">=14.0.0"
6464
},
6565
"packageManager": "[email protected]",
6666
"lint-staged": {

src/transforms/v2-to-v3/transformer.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import { readdirSync, readFileSync } from "fs";
2+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
3+
// @ts-ignore: Could not find a declaration file for module 'jscodeshift/dist/testUtils'
24
import { runInlineTest } from "jscodeshift/dist/testUtils";
35
import { join } from "path";
46

src/transforms/v2-to-v3/transformer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default function transformer(file: FileInfo, api: API) {
1717
const j = api.jscodeshift;
1818
const source = j(file.source);
1919

20-
const v2DefaultModuleName = getV2DefaultModuleName(j, source);
20+
const v2DefaultModuleName = getV2DefaultModuleName(j, source) as string;
2121
const v2ServiceModuleNames = getV2ServiceModuleNames(j, source);
2222
if (!v2DefaultModuleName && v2ServiceModuleNames.length === 0) {
2323
return source.toSource();

src/transforms/v2-to-v3/utils/addV3ClientImport.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export const addV3ClientImport = (
1717
if (existingImports.size()) {
1818
existingImports.forEach((nodePath) => {
1919
// Append to existing import if specifier not present.
20-
if (!nodePath.value.specifiers.find((specifier) => specifier.local.name === v3ClientName)) {
21-
nodePath.value.specifiers.push(j.importSpecifier(j.identifier(v3ClientName)));
20+
if (!nodePath.value.specifiers?.find((specifier) => specifier.local?.name === v3ClientName)) {
21+
nodePath.value.specifiers?.push(j.importSpecifier(j.identifier(v3ClientName)));
2222
}
2323
});
2424
return;

src/transforms/v2-to-v3/utils/config/CLIENT_NAMES_MAP.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { CLIENT_NAMES } from "./CLIENT_NAMES";
22

3-
export const CLIENT_NAMES_MAP = {
3+
export const CLIENT_NAMES_MAP: Record<string, string> = {
44
...CLIENT_NAMES.reduce((acc, name) => ({ ...acc, [name]: name }), {}),
55
AugmentedAIRuntime: "SageMakerA2IRuntime",
66
CUR: "CostAndUsageReportService",

src/transforms/v2-to-v3/utils/config/CLIENT_PACKAGE_NAMES_MAP.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { CLIENT_NAMES } from "./CLIENT_NAMES";
22

3-
export const CLIENT_PACKAGE_NAMES_MAP = {
3+
export const CLIENT_PACKAGE_NAMES_MAP: Record<string, string> = {
44
...CLIENT_NAMES.reduce(
55
(acc, name) => ({
66
...acc,

src/transforms/v2-to-v3/utils/getImportIdentifierName.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ export const getImportIdentifierName = (
99
.find(j.ImportDeclaration, {
1010
source: { value: literalValue },
1111
})
12-
.nodes()[0]?.specifiers[0]?.local.name;
12+
.nodes()[0]?.specifiers?.[0]?.local?.name;

src/transforms/v2-to-v3/utils/getV2ServiceModuleNames.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ import { getV2ServiceModulePath } from "./getV2ServiceModulePath";
99
export const getV2ServiceModuleNames = (j: JSCodeshift, source: Collection<unknown>): string[] =>
1010
CLIENT_NAMES.map((clientName) =>
1111
containsRequire(j, source)
12-
? getRequireIdentifierName(j, source, getV2ServiceModulePath(clientName))
13-
: getImportIdentifierName(j, source, getV2ServiceModulePath(clientName))
12+
? (getRequireIdentifierName(j, source, getV2ServiceModulePath(clientName)) as string)
13+
: (getImportIdentifierName(j, source, getV2ServiceModulePath(clientName)) as string)
1414
).filter((v2ServiceModuleName) => v2ServiceModuleName !== undefined);

0 commit comments

Comments
 (0)