chore: throw errors where we expect identifier.name as string

Author: trivikr

src/transforms/v2-to-v3/modules/importEqualsModule/getImportSpecifiers.ts

@@ -10,7 +10,11 @@ export const getImportSpecifiers = (
   const importSpecifiers = new Set<ImportSpecifierType>();
 
   getImportEqualsDeclarations(j, source, path).forEach((importEqualsDeclaration) => {
-    importSpecifiers.add({ localName: importEqualsDeclaration.value.id.name });
+    const localName = importEqualsDeclaration.value.id.name;
+    if (typeof localName !== "string") {
+      throw new Error("Please report your use case on https://github.com/aws/aws-sdk-js-codemod");
+    }
+    importSpecifiers.add({ localName });
   });
 
   return Array.from(importSpecifiers);

src/transforms/v2-to-v3/modules/importEqualsModule/removeImportEquals.ts

@@ -8,6 +8,9 @@ const isAnotherSpecifier = (j: JSCodeshift, source: Collection<unknown>, localNa
 export const removeImportEquals = (j: JSCodeshift, source: Collection<unknown>) =>
   getImportEqualsDeclarations(j, source).forEach((importEqualsDeclaration) => {
     const localName = importEqualsDeclaration.value.id.name;
+    if (typeof localName !== "string") {
+      throw new Error("Please report your use case on https://github.com/aws/aws-sdk-js-codemod");
+    }
     const identifiers = source.find(j.Identifier, { name: localName });
 
     // Either the identifier is the only occurence on the page.

src/transforms/v2-to-v3/modules/importModule/getImportSpecifiers.ts

@@ -15,16 +15,28 @@ export const getImportSpecifiers = (
       switch (specifier.type) {
         case "ImportSpecifier": {
           const importedName = specifier.imported.name;
+          const localName = specifier.local?.name;
+          if (typeof importedName !== "string" || (localName && typeof localName !== "string")) {
+            throw new Error(
+              "Please report your use case on https://github.com/aws/aws-sdk-js-codemod"
+            );
+          }
           importSpecifiers.add({
             importedName,
-            localName: specifier.local?.name || importedName,
+            localName: localName || importedName,
           });
           break;
         }
         case "ImportNamespaceSpecifier":
         case "ImportDefaultSpecifier": {
           if (specifier.local) {
-            importSpecifiers.add({ localName: specifier.local.name });
+            const localName = specifier.local.name;
+            if (typeof localName !== "string") {
+              throw new Error(
+                "Please report your use case on https://github.com/aws/aws-sdk-js-codemod"
+              );
+            }
+            importSpecifiers.add({ localName });
           }
           break;
         }

src/transforms/v2-to-v3/modules/importModule/removeImport.ts

@@ -22,6 +22,11 @@ export const removeImport = (j: JSCodeshift, source: Collection<unknown>) =>
         if (!localName) {
           return true;
         }
+        if (typeof localName !== "string") {
+          throw new Error(
+            "Please report your use case on https://github.com/aws/aws-sdk-js-codemod"
+          );
+        }
         const identifiers = source.find(j.Identifier, { name: localName });
         const importedName = specifier.type === "ImportSpecifier" && specifier.imported?.name;
 

src/transforms/v2-to-v3/modules/importSpecifierCompareFn.ts

@@ -9,25 +9,42 @@ export const importSpecifierCompareFn = (
   specifier2: ImportSpecifier | ImportDefaultSpecifier | ImportNamespaceSpecifier
 ) => {
   if (specifier1.type === "ImportSpecifier" && specifier2.type === "ImportSpecifier") {
-    return specifier1.imported.name.localeCompare(specifier2.imported.name);
+    const specifier1ImportedName = specifier1.imported.name;
+    const specifier2ImportedName = specifier2.imported.name;
+    if (typeof specifier1ImportedName !== "string" || typeof specifier2ImportedName !== "string") {
+      throw new Error("Please report your use case on https://github.com/aws/aws-sdk-js-codemod");
+    }
+    return specifier1ImportedName.localeCompare(specifier2ImportedName);
   }
 
   if (
     specifier1.type === "ImportDefaultSpecifier" &&
     specifier2.type === "ImportDefaultSpecifier"
   ) {
-    if (specifier1.local && specifier2.local)
-      return specifier1.local.name.localeCompare(specifier2.local.name);
-    return 0;
+    if (!specifier1.local || !specifier2.local) {
+      return 0;
+    }
+    const specifier1LocalName = specifier1.local.name;
+    const specifier2LocalName = specifier2.local.name;
+    if (typeof specifier1LocalName !== "string" || typeof specifier2LocalName !== "string") {
+      throw new Error("Please report your use case on https://github.com/aws/aws-sdk-js-codemod");
+    }
+    return specifier1LocalName.localeCompare(specifier2LocalName);
   }
 
   if (
     specifier1.type === "ImportNamespaceSpecifier" &&
     specifier2.type === "ImportNamespaceSpecifier"
   ) {
-    if (specifier1.local && specifier2.local)
-      return specifier1.local.name.localeCompare(specifier2.local.name);
-    return 0;
+    if (!specifier1.local || !specifier2.local) {
+      return 0;
+    }
+    const specifier1LocalName = specifier1.local.name;
+    const specifier2LocalName = specifier2.local.name;
+    if (typeof specifier1LocalName !== "string" || typeof specifier2LocalName !== "string") {
+      throw new Error("Please report your use case on https://github.com/aws/aws-sdk-js-codemod");
+    }
+    return specifier1LocalName.localeCompare(specifier2LocalName);
   }
 
   return 0;