Skip to content

Commit d21db67

Browse files
authored
Move v2GlobalName undefined check inside removeGlobalModule (#521)
1 parent cc75eb1 commit d21db67

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/transforms/v2-to-v3/modules/removeGlobalModule.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@ import { removeImportDefault } from "./removeImportDefault";
77
import { removeImportEquals } from "./removeImportEquals";
88
import { removeRequireIdentifier } from "./removeRequireIdentifier";
99

10+
// Removes the import of "aws-sdk" if it's not used.
1011
export const removeGlobalModule = (
1112
j: JSCodeshift,
1213
source: Collection<unknown>,
13-
v2GlobalName: string
14+
v2GlobalName?: string
1415
) => {
16+
if (!v2GlobalName) return;
17+
1518
const identifierUsages = source.find(j.Identifier, { name: v2GlobalName });
1619

1720
// Only usage is import/require.

src/transforms/v2-to-v3/transformer.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,7 @@ const transformer = async (file: FileInfo, api: API) => {
6363
replaceClientCreation(j, source, v2Options);
6464
replaceDocClientCreation(j, source, v2Options);
6565
}
66-
67-
if (v2GlobalName) {
68-
removeGlobalModule(j, source, v2GlobalName);
69-
}
66+
removeGlobalModule(j, source, v2GlobalName);
7067

7168
return source.toSource();
7269
};

0 commit comments

Comments
 (0)