Move DynamoDB clientName check inside replaceDocClientCreation (#518)

Author: trivikr

src/transforms/v2-to-v3/client-instances/replaceDocClientCreation.ts

@@ -1,18 +1,22 @@
 import { Collection, JSCodeshift } from "jscodeshift";
 
+import { DYNAMODB } from "../config";
 import { getDocClientNewExpression } from "../utils";
 import { getDynamoDBForDocClient } from "./getDynamoDBForDocClient";
 
 export interface ReplaceDocClientCreationOptions {
+  v2ClientName: string;
   v2ClientLocalName: string;
   v2GlobalName?: string;
 }
 
 export const replaceDocClientCreation = (
   j: JSCodeshift,
   source: Collection<unknown>,
-  { v2ClientLocalName, v2GlobalName }: ReplaceDocClientCreationOptions
+  { v2ClientName, v2ClientLocalName, v2GlobalName }: ReplaceDocClientCreationOptions
 ): void => {
+  if (v2ClientName !== DYNAMODB) return;
+
   if (v2GlobalName) {
     source
       .find(j.NewExpression, getDocClientNewExpression({ v2GlobalName }))

src/transforms/v2-to-v3/transformer.ts

@@ -8,7 +8,6 @@ import {
   getClientNamesFromGlobal,
   getClientNamesRecord,
 } from "./client-names";
-import { DYNAMODB } from "./config";
 import {
   addClientModules,
   getGlobalNameFromModule,
@@ -65,9 +64,7 @@ const transformer = async (file: FileInfo, api: API) => {
       replaceClientCreation(j, source, { v2ClientName, v2ClientLocalName, v2GlobalName });
     }
 
-    if (v2ClientName === DYNAMODB) {
-      replaceDocClientCreation(j, source, { v2ClientLocalName, v2GlobalName });
-    }
+    replaceDocClientCreation(j, source, v2Options);
   }
 
   if (v2GlobalName) {