Use optional chain instead of chained logical expressions (#896)

trivikr · web-flow · commit e66c64b17130 · 2024-07-12T07:49:53.000-07:00
diff --git a/.changeset/nasty-peaches-complain.md b/.changeset/nasty-peaches-complain.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Use optional chain instead of chained logical expressions
diff --git a/biome.json b/biome.json
@@ -13,8 +13,7 @@
     "rules": {
       "recommended": true,
       "complexity": {
-        "noForEach": "off",
-        "useOptionalChain": "off"
+        "noForEach": "off"
       },
       "correctness": {
         "noNewSymbol": "error",
diff --git a/src/transforms/v2-to-v3/utils/isTrailingCommaUsed.ts b/src/transforms/v2-to-v3/utils/isTrailingCommaUsed.ts
@@ -3,7 +3,7 @@ import type { Collection, JSCodeshift } from "jscodeshift";
 export const isTrailingCommaUsed = (j: JSCodeshift, source: Collection<unknown>) => {
   for (const node of source.find(j.ObjectExpression).nodes()) {
     // @ts-ignore Property 'extra' does not exist on type 'ObjectExpression'.
-    if (node.extra && node.extra.trailingComma) {
+    if (node.extra?.trailingComma) {
       return true;
     }
   }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"aws-sdk-js-codemod": patch
 +---
++
 +Use optional chain instead of chained logical expressions
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import type { Collection, JSCodeshift } from "jscodeshift";`
`3`	`3`	`export const isTrailingCommaUsed = (j: JSCodeshift, source: Collection<unknown>) => {`
`4`	`4`	`for (const node of source.find(j.ObjectExpression).nodes()) {`
`5`	`5`	`// @ts-ignore Property 'extra' does not exist on type 'ObjectExpression'.`
`6`		`- if (node.extra && node.extra.trailingComma) {`
	`6`	`+ if (node.extra?.trailingComma) {`
`7`	`7`	`return true;`
`8`	`8`	`}`
`9`	`9`	`}`