Skip to content

Commit 0a251aa

Browse files
authored
feat: support Sigv4 for non AWS services (#2385)
* feat(middleware-signing): support SigV4 for non AWS services There is no regionInfo to determine signingService. The signingName will instead directly come from input. And region will be used as signingRegion. * feat(codegen): support SigV4 for non AWS services Write `signingName` from the SigV4 trait for non AWS service. `region` is used for the signingRegion. A separate SigV4Auth is used for SigV4 logic for non AWS services. * fix(codegen): use Region plugin explicitly for AWS service The models for the protocol tests don't seem to have the SigV4 trait, so can't rely solely on it for using the Region plugin. e.g, https://github.com/awslabs/smithy/blob/main/smithy-aws-protocol-tests/model/restJson1/main.smithy#L11-L13 * chore(clients): update clients with updates for SigV4 for non AWS services * test(middleware-signing): add test for non AWS service SigV4 * chore(codegen): reduce duplication for writing region * Reverting unnecessary changes to protocol tests
1 parent 3110d62 commit 0a251aa

File tree

271 files changed

+493
-322
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

271 files changed

+493
-322
lines changed

clients/client-accessanalyzer/AccessAnalyzerClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
235235
serviceId?: string;
236236

237237
/**
238-
* The AWS region to which this client will send requests or use as signingRegion
238+
* The AWS region to which this client will send requests
239239
*/
240240
region?: string | __Provider<string>;
241241

clients/client-acm-pca/ACMPCAClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
235235
serviceId?: string;
236236

237237
/**
238-
* The AWS region to which this client will send requests or use as signingRegion
238+
* The AWS region to which this client will send requests
239239
*/
240240
region?: string | __Provider<string>;
241241

clients/client-acm/ACMClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
196196
serviceId?: string;
197197

198198
/**
199-
* The AWS region to which this client will send requests or use as signingRegion
199+
* The AWS region to which this client will send requests
200200
*/
201201
region?: string | __Provider<string>;
202202

clients/client-alexa-for-business/AlexaForBusinessClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
523523
serviceId?: string;
524524

525525
/**
526-
* The AWS region to which this client will send requests or use as signingRegion
526+
* The AWS region to which this client will send requests
527527
*/
528528
region?: string | __Provider<string>;
529529

clients/client-amp/AmpClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
145145
serviceId?: string;
146146

147147
/**
148-
* The AWS region to which this client will send requests or use as signingRegion
148+
* The AWS region to which this client will send requests
149149
*/
150150
region?: string | __Provider<string>;
151151

clients/client-amplify/AmplifyClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
268268
serviceId?: string;
269269

270270
/**
271-
* The AWS region to which this client will send requests or use as signingRegion
271+
* The AWS region to which this client will send requests
272272
*/
273273
region?: string | __Provider<string>;
274274

clients/client-amplifybackend/AmplifyBackendClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
214214
serviceId?: string;
215215

216216
/**
217-
* The AWS region to which this client will send requests or use as signingRegion
217+
* The AWS region to which this client will send requests
218218
*/
219219
region?: string | __Provider<string>;
220220

clients/client-api-gateway/APIGatewayClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
596596
serviceId?: string;
597597

598598
/**
599-
* The AWS region to which this client will send requests or use as signingRegion
599+
* The AWS region to which this client will send requests
600600
*/
601601
region?: string | __Provider<string>;
602602

clients/client-apigatewaymanagementapi/ApiGatewayManagementApiClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
133133
serviceId?: string;
134134

135135
/**
136-
* The AWS region to which this client will send requests or use as signingRegion
136+
* The AWS region to which this client will send requests
137137
*/
138138
region?: string | __Provider<string>;
139139

clients/client-apigatewayv2/ApiGatewayV2Client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
382382
serviceId?: string;
383383

384384
/**
385-
* The AWS region to which this client will send requests or use as signingRegion
385+
* The AWS region to which this client will send requests
386386
*/
387387
region?: string | __Provider<string>;
388388

0 commit comments

Comments
 (0)