chore: improved async iterable error handling with minimal performance impact

Author: lukachad

lib/lib-storage/src/s3-transfer-manager/S3TransferManager.e2e.spec.ts

@@ -238,12 +238,18 @@ describe(S3TransferManager.name, () => {
         }).done();
         const tm: S3TransferManager = mode === "PART" ? tmPart : tmRange;
         const controller = new AbortController();
-        setTimeout(() => controller.abort(), 100);
         try {
           await tm.download(
             { Bucket, Key },
             {
               abortSignal: controller.signal,
+              eventListeners: {
+                transferInitiated: [
+                  () => {
+                    controller.abort();
+                  },
+                ],
+              },
             }
           );
           expect.fail("Download should have been aborted");

lib/lib-storage/src/s3-transfer-manager/join-streams.ts

@@ -25,9 +25,8 @@ export async function joinStreams(
     });
     return sdkStreamMixin(newReadableStream);
   } else {
-    // TODO: The following line is a temp fix to handle error thrown in async iterable.
-    // We should find a better solution to improve performance.
-    await Promise.all(streams);
+    streams.forEach((stream) => stream.catch(() => {}));
+
     return sdkStreamMixin(Readable.from(iterateStreams(streams, eventListeners)));
   }
 }