Skip to content

Commit 3260357

Browse files
authored
test(aws-restjson-server): confirm query values of 0 and false are serialized (#6010)
1 parent 5331483 commit 3260357

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -316,13 +316,6 @@ private static boolean filterProtocolTests(
316316
return true;
317317
}
318318

319-
// TODO: Remove when this test case is fixed upstream.
320-
// https://github.com/smithy-lang/smithy/pull/2167
321-
if (settings.generateServerSdk()
322-
&& testCase.getId().equals("RestJsonZeroAndFalseQueryValues")) {
323-
return true;
324-
}
325-
326319
// TODO: remove when there's a decision on separator to use
327320
// https://github.com/awslabs/smithy/issues/1014
328321
if (testCase.getId().equals("RestJsonInputAndOutputWithQuotedStringHeaders")) {

private/aws-restjson-server/test/functional/restjson1.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ it("RestJsonSupportsNegativeInfinityFloatQueryValues:ServerRequest", async () =>
795795
/**
796796
* Query values of 0 and false are serialized
797797
*/
798-
it.skip("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
798+
it("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
799799
const testFunction = jest.fn();
800800
testFunction.mockReturnValue(Promise.resolve({}));
801801
const testService: Partial<RestJsonService<{}>> = {

0 commit comments

Comments
 (0)