account for lowercase xray trace headers during middleware-recursion-detection

Author: jj22ee

packages/middleware-recursion-detection/src/index.spec.ts

@@ -70,6 +70,27 @@ describe(recursionDetectionMiddleware.name, () => {
     expect(request.headers[TRACE_ID_HEADER_NAME]).toBe("some-real-trace-id");
   });
 
+  it(`should NOT set ${TRACE_ID_HEADER_NAME} header when the header is already set in all lowercase`, async () => {
+    process.env = {
+      AWS_LAMBDA_FUNCTION_NAME: "some-function",
+      _X_AMZN_TRACE_ID: "some-trace-id",
+    };
+    const handler = recursionDetectionMiddleware({ runtime: "node" })(mockNextHandler, {} as any);
+    await handler({
+      input: {},
+      request: new HttpRequest({
+        headers: {
+          [TRACE_ID_HEADER_NAME.toLowerCase()]: "some-real-trace-id",
+        },
+      }),
+    });
+
+    const { calls } = (mockNextHandler as any).mock;
+    expect(calls.length).toBe(1);
+    const { request } = mockNextHandler.mock.calls[0][0];
+    expect(request.headers[TRACE_ID_HEADER_NAME.toLowerCase()]).toBe("some-real-trace-id");
+  });
+
   it("has no effect for browser runtime", async () => {
     process.env = {
       AWS_LAMBDA_FUNCTION_NAME: "some-function",

packages/middleware-recursion-detection/src/index.ts

@@ -30,7 +30,9 @@ export const recursionDetectionMiddleware =
     if (
       !HttpRequest.isInstance(request) ||
       options.runtime !== "node" ||
-      request.headers.hasOwnProperty(TRACE_ID_HEADER_NAME)
+      Object.keys(request.headers).some(
+        (key) => key.toLowerCase() === TRACE_ID_HEADER_NAME.toLowerCase()
+      )
     ) {
       return next(args);
     }