Skip to content

Commit 6437e24

Browse files
authored
fix(client-s3): fix union serialization (#1730)
* chore: fix serializing unions in XML * fix(client-s3): fix union serialization
1 parent 891eae2 commit 6437e24

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

clients/client-s3/protocols/Aws_restXml.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10152,7 +10152,7 @@ const serializeAws_restXmlAnalyticsFilter = (input: AnalyticsFilter, context: __
1015210152
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
1015310153
throw new Error("Unable to serialize unknown union members in XML.");
1015410154
}
10155-
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
10155+
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
1015610156
},
1015710157
});
1015810158
return bodyNode;
@@ -11022,7 +11022,7 @@ const serializeAws_restXmlLifecycleRuleFilter = (input: LifecycleRuleFilter, con
1102211022
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
1102311023
throw new Error("Unable to serialize unknown union members in XML.");
1102411024
}
11025-
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
11025+
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
1102611026
},
1102711027
});
1102811028
return bodyNode;
@@ -11130,7 +11130,7 @@ const serializeAws_restXmlMetricsFilter = (input: MetricsFilter, context: __Serd
1113011130
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
1113111131
throw new Error("Unable to serialize unknown union members in XML.");
1113211132
}
11133-
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
11133+
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
1113411134
},
1113511135
});
1113611136
return bodyNode;
@@ -11572,7 +11572,7 @@ const serializeAws_restXmlReplicationRuleFilter = (input: ReplicationRuleFilter,
1157211572
if (!(value instanceof __XmlNode || value instanceof __XmlText)) {
1157311573
throw new Error("Unable to serialize unknown union members in XML.");
1157411574
}
11575-
bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));
11575+
bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));
1157611576
},
1157711577
});
1157811578
return bodyNode;

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ protected void serializeUnion(GenerationContext context, UnionShape shape) {
293293
});
294294

295295
// Set the node explicitly for potentially correct cases.
296-
writer.write("bodyNode.addChildNode(new __XmlNode(value).addChildNode(value));");
296+
writer.write("bodyNode.addChildNode(new __XmlNode(name).addChildNode(value));");
297297
});
298298
});
299299

0 commit comments

Comments
 (0)