fix(core/protocols): read error code case-insensitively (#7085)

* fix(core/protocols): read json error code case-insensitively

* chore: unused imports

Author: kuhe

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsSmithyRpcV2Cbor.java

@@ -6,6 +6,7 @@
 package software.amazon.smithy.aws.typescript.codegen;
 
 import software.amazon.smithy.aws.traits.protocols.AwsQueryCompatibleTrait;
+import software.amazon.smithy.typescript.codegen.SmithyCoreSubmodules;
 import software.amazon.smithy.typescript.codegen.TypeScriptDependency;
 import software.amazon.smithy.typescript.codegen.TypeScriptWriter;
 import software.amazon.smithy.typescript.codegen.integration.ProtocolGenerator;
@@ -55,15 +56,18 @@ protected void writeSharedRequestHeaders(ProtocolGenerator.GenerationContext con
 
     @Override
     protected void writeErrorCodeParser(GenerationContext generationContext) {
-        super.writeErrorCodeParser(generationContext);
         TypeScriptWriter writer = generationContext.getWriter();
-
         if (generationContext.getService().hasTrait(AwsQueryCompatibleTrait.class)) {
             // Populate parsedOutput.body with 'Code' and 'Type' fields
             // "x-amzn-query-error" header is available when AwsQueryCompatibleTrait is applied to a service
             // The header value contains query error Code and Type joined by ';'
             // E.g. "MalformedInput;Sender" or "InternalFailure;Receiver"
             writer.write("populateBodyWithQueryCompatibility(parsedOutput, output.headers);");
         }
+        writer.addImportSubmodule(
+            "loadSmithyRpcV2CborErrorCode", null,
+            TypeScriptDependency.SMITHY_CORE, SmithyCoreSubmodules.CBOR
+        );
+        writer.write("const errorCode = loadSmithyRpcV2CborErrorCode(output, parsedOutput.body);");
     }
 }

packages/core/src/submodules/protocols/json/parseJsonBody.spec.ts

@@ -0,0 +1,15 @@
+import { describe, expect, test as it } from "vitest";
+
+import { loadRestJsonErrorCode } from "./parseJsonBody";
+
+describe(loadRestJsonErrorCode.name, () => {
+  it("reads the code of the error case-insensitively", () => {
+    const code = loadRestJsonErrorCode(
+      { statusCode: 200, headers: {} },
+      {
+        cOdE: "OhNoException:Sender",
+      }
+    );
+    expect(code).toEqual("OhNoException");
+  });
+});

packages/core/src/submodules/protocols/json/parseJsonBody.ts

@@ -59,11 +59,14 @@ export const loadRestJsonErrorCode = (output: HttpResponse, data: any): string |
     return sanitizeErrorCode(output.headers[headerKey]);
   }
 
-  if (data.code !== undefined) {
-    return sanitizeErrorCode(data.code);
-  }
+  if (data && typeof data === "object") {
+    const codeKey = findKey(data, "code");
+    if (codeKey && data[codeKey] !== undefined) {
+      return sanitizeErrorCode(data[codeKey]);
+    }
 
-  if (data["__type"] !== undefined) {
-    return sanitizeErrorCode(data["__type"]);
+    if (data["__type"] !== undefined) {
+      return sanitizeErrorCode(data["__type"]);
+    }
   }
 };