fix(cloudfront-signer): changing the type of dateLessThan and dateGreaterThan

Author: smilkuri

packages/cloudfront-signer/src/sign.spec.ts

@@ -638,14 +638,14 @@ describe("getSignedUrl- when signing a URL with a date range", () => {
     const resultUrl = getSignedUrl({
       url,
       keyPairId,
-      dateLessThan: dateNumber as unknown as string,
+      dateLessThan: dateNumber,
       privateKey,
       passphrase,
     });
     const resultCookies = getSignedCookies({
       url,
       keyPairId,
-      dateLessThan: dateNumber as unknown as string,
+      dateLessThan: dateNumber,
       privateKey,
       passphrase,
     });
@@ -658,14 +658,14 @@ describe("getSignedUrl- when signing a URL with a date range", () => {
     const resultUrl = getSignedUrl({
       url,
       keyPairId,
-      dateLessThan: dateObject as unknown as string,
+      dateLessThan: dateObject,
       privateKey,
       passphrase,
     });
     const resultCookies = getSignedCookies({
       url,
       keyPairId,
-      dateLessThan: dateObject as unknown as string,
+      dateLessThan: dateObject,
       privateKey,
       passphrase,
     });
@@ -709,8 +709,8 @@ describe("getSignedUrl- when signing a URL with a date range", () => {
     const result = getSignedUrl({
       url,
       keyPairId,
-      dateLessThan: dateNumber as unknown as string,
-      dateGreaterThan: dateGreaterThanNumber as unknown as string,
+      dateLessThan: dateNumber,
+      dateGreaterThan: dateGreaterThanNumber,
       privateKey,
       passphrase,
     });
@@ -740,8 +740,8 @@ describe("getSignedUrl- when signing a URL with a date range", () => {
     const result = getSignedUrl({
       url,
       keyPairId,
-      dateLessThan: dateObject as unknown as string,
-      dateGreaterThan: dateGreaterThanObject as unknown as string,
+      dateLessThan: dateObject,
+      dateGreaterThan: dateGreaterThanObject,
       privateKey,
       passphrase,
     });

packages/cloudfront-signer/src/sign.ts

@@ -25,9 +25,9 @@ export type CloudfrontSignInputWithParameters = CloudfrontSignerCredentials & {
   /** The URL string to sign. */
   url: string;
   /** The date string for when the signed URL or cookie can no longer be accessed */
-  dateLessThan: string;
+  dateLessThan: string | number | Date;
   /** The date string for when the signed URL or cookie can start to be accessed. */
-  dateGreaterThan?: string;
+  dateGreaterThan?: string | number | Date;
   /** The IP address string to restrict signed URL access to. */
   ipAddress?: string;
   /**
@@ -367,7 +367,7 @@ class CloudfrontSignBuilder {
     return isNaN(parsedDate.getTime()) ? undefined : this.epochTime(parsedDate);
   }
 
-  private parseDateWindow(expiration: string, start?: string): PolicyDates {
+  private parseDateWindow(expiration: string | number | Date, start?: string | number | Date): PolicyDates {
     const dateLessThan = this.parseDate(expiration);
     if (!dateLessThan) {
       throw new Error("dateLessThan is invalid. Ensure the date string is compatible with the Date constructor.");
@@ -400,8 +400,8 @@ class CloudfrontSignBuilder {
     ipAddress,
   }: {
     url?: string;
-    dateLessThan?: string;
-    dateGreaterThan?: string;
+    dateLessThan?: string | number | Date;
+    dateGreaterThan?: string | number | Date;
     ipAddress?: string;
   }) {
     if (!url || !dateLessThan) {